Add support for Helm 3 in tests #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrancato
force-pushed
the
helm_3_tests
branch
from
b0a5a29
to
c0752b0
Compare
|
@mbrancato This has conflicts, can you resolve them? |
mbrancato
force-pushed
the
helm_3_tests
branch
from
c0752b0
to
6d3e4ba
Compare
|
Hi @jasonodonnell - I rebased this and updated the new tests that were in conflict. |
|
Sorry @mbrancato, we got busy here :) I think we are ready to review this, can you rebase this one more time? |
jasonodonnell
requested review from
tvoran
and removed request for
jasonodonnell
|
Thanks for the contribution! We've decided to continue this in another PR. Superseded by #195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some syntax changes and some slight behavior changes in the Helm 3 cli. This PR adds support for these.