Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to set extra volume mode #321

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Conversation

omerlh
Copy link
Contributor

@omerlh omerlh commented Jun 4, 2020

Currently there is no way to mount start up script that can be used for post start - the file permission are set to the default, 420, which is not executable. This PR allows to set the file permission.

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 4, 2020

CLA assistant check
All committers have signed the CLA.

@jasonodonnell
Copy link
Contributor

Thanks @omerlh!

This looks good but you'll need to sign the CLA.

@omerlh
Copy link
Contributor Author

omerlh commented Jun 4, 2020

Working on that with our legal team :)

@omerlh
Copy link
Contributor Author

omerlh commented Jun 7, 2020

CLA signed 👏

@omerlh
Copy link
Contributor Author

omerlh commented Jun 11, 2020

hey @jasonodonnell any chance this can be merged? 🙏

Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jasonodonnell jasonodonnell merged commit 5a7e10c into hashicorp:master Jun 11, 2020
@omerlh omerlh deleted the patch-1 branch June 11, 2020 16:48
@omerlh
Copy link
Contributor Author

omerlh commented Jun 11, 2020

Yay! Thanks! When will it be released?

@jasonodonnell
Copy link
Contributor

No firm date yet, but we'll be merging a few more features soon. Probably sometime in early July.

@jasonodonnell jasonodonnell mentioned this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants