support extraLabels for vault-agent-injector

[logileifs]

fixes issue #427

[hashicorp-cla]

All committers have signed the CLA.

[jasonodonnell]

Hi @logileifs, thanks for the contribution!

This looks good but will require unit tests to make sure the configurable works and has coverage. Would you mind adding some? You can find the bats injector unit tests here: https://github.com/hashicorp/vault-helm/blob/master/test/unit/injector-deployment.bats.

Here's a test that's equivalent: https://github.com/hashicorp/vault-helm/blob/master/test/unit/server-statefulset.bats#L891-L901.

[jasonodonnell]

@logileifs Also the CLA will need to be signed 😄

[logileifs]

Hey @jasonodonnell thanks for the tips, I added a test for the extraLabels on the injector and I have already signed the CLA, I don't know why it's not updating 😕

[logileifs]

I figured out what the problem was, everything should be in order now :)

[jasonodonnell]

One last change, this needs to be added to the values.yaml file. You can set it to blank just we like we do for server:

injector:
  ...
  extraLabels: {}

[jasonodonnell]

LGTM, thanks for the contribution!

[logileifs]

Thanks for the quick response @jasonodonnell and just out of curiosity, when can I expect to see this change in a release?

[jasonodonnell]

We release monthly (if there's things to be released) on the third Tuesday, so good chance you'll see it then.