Set VAULT_DEV_LISTEN_ADDRESS in dev mode #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binds vault to 0.0.0.0 in dev mode so that external traffic is accepted.
This was referenced Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses hashicorp/vault-k8s#206
Since vault in dev mode now binds to localhost (127.0.0.1) by default, this adds the environment variable VAULT_DEV_LISTEN_ADDRESS to the server statefulset so that vault will accept traffic from outside the pod.
Also adds a couple tests for the new var, and modifies one that was affected by the extra env var added to the pod spec.