-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dual stack clusters #833
Conversation
Hi, anything needed from my end to push this forward? Really don't want to sound pushy in any way, just curious what my best course of action is, even if that action is inaction and simple patience on my end :-) |
Looking for this feature too, as I see on other PR @UXabre maybe you can ask for a review of hashicorp team to push it further ? |
I've updated this PR to resolve the conflict, if somebody could review this? :-) EDIT: Also added unit tests |
@hsimon-hashicorp Maybe you can help me with this PR? As I see nobody has reviewed it yet and perhaps you are my last hope :-) (sorry for spamming) |
903ff28
to
08734c8
Compare
Not spam at all, this is my job. :) I've pinged our engineers to see if one can help with a review. Thanks! |
joining waitlist :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, left a couple thoughts. And should we set these parameters in templates/server-headless-service.yaml
as well?
I've also added this to headless :-) |
All changes have been applied and I've rebased with main just to be on the safe side :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Adds support for dual stack clusters
resolves: #832