Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dual stack clusters #833

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

UXabre
Copy link
Contributor

@UXabre UXabre commented Jan 24, 2023

Adds support for dual stack clusters

resolves: #832

@tvoran tvoran added enhancement New feature or request vault-server Area: operation and usage of vault server in k8s labels Mar 25, 2023
@UXabre
Copy link
Contributor Author

UXabre commented Apr 17, 2023

Hi, anything needed from my end to push this forward? Really don't want to sound pushy in any way, just curious what my best course of action is, even if that action is inaction and simple patience on my end :-)

@M0NsTeRRR
Copy link

Looking for this feature too, as I see on other PR @UXabre maybe you can ask for a review of hashicorp team to push it further ?

@UXabre
Copy link
Contributor Author

UXabre commented Aug 7, 2023

I've updated this PR to resolve the conflict, if somebody could review this? :-)

EDIT: Also added unit tests

@UXabre
Copy link
Contributor Author

UXabre commented Aug 7, 2023

@hsimon-hashicorp Maybe you can help me with this PR? As I see nobody has reviewed it yet and perhaps you are my last hope :-) (sorry for spamming)

@UXabre UXabre force-pushed the feature/832 branch 9 times, most recently from 903ff28 to 08734c8 Compare August 7, 2023 13:47
@heatherezell
Copy link

@hsimon-hashicorp Maybe you can help me with this PR? As I see nobody has reviewed it yet and perhaps you are my last hope :-) (sorry for spamming)

Not spam at all, this is my job. :) I've pinged our engineers to see if one can help with a review. Thanks!

@belyaev-dev
Copy link

joining waitlist :)

Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left a couple thoughts. And should we set these parameters in templates/server-headless-service.yaml as well?

test/unit/server-service.bats Show resolved Hide resolved
values.yaml Show resolved Hide resolved
@hashicorp-cla
Copy link

hashicorp-cla commented Aug 23, 2023

CLA assistant check
All committers have signed the CLA.

@UXabre
Copy link
Contributor Author

UXabre commented Aug 23, 2023

Thanks, left a couple thoughts. And should we set these parameters in templates/server-headless-service.yaml as well?

I've also added this to headless :-)

@UXabre
Copy link
Contributor Author

UXabre commented Aug 23, 2023

All changes have been applied and I've rebased with main just to be on the safe side :-)

templates/ui-service.yaml Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tvoran tvoran merged commit 377b68f into hashicorp:main Aug 24, 2023
1 check passed
@UXabre UXabre deleted the feature/832 branch August 25, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vault-server Area: operation and usage of vault server in k8s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for setting ipFamilyPolicy on service
6 participants