Fix check if server.ha.replicas is a number when set in values.yaml #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschoche
approved these changes
Oct 4, 2023
|
I've just stumbled across this issue, when is it expected to be merged and released in the chart? |
|
I am also facing this issue, my vault helm chart defaulted to 3 causing some undesire behaviours in my cluster, I hope this get merge and released asap. |
|
Just found your PR to be merged, after digging into this issue for over 1 hour. Thanks a million! |
|
Sorry about this, I had approved the PR but forgotten to merge, I'll try to get a release out ASAP with this fix. |
|
Hi - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits merged in #943 only work when using
--set 'server.ha.replicas=2'from the CLI, not whenserver.ha.replicasis defined invalues.yaml. This behaviour is expected and described in helm/helm#12084. You can see this in action on this playground.This passes the unit tests because they don't use values.yaml, so only the CLI behaviour is tested and this passed without raising issues.
By checking if the value is either
int64orfloat64, both cases work. There are no other cases where a value is checked if it'sint64, so this should not occur anywhere else in this chart.