Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only inject Pods that are Pending. #501

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Only inject Pods that are Pending. #501

merged 1 commit into from
Aug 16, 2023

Conversation

cjyar
Copy link
Contributor

@cjyar cjyar commented Jul 17, 2023 •
edited
Loading

Fixes #500.

@cjyar cjyar mentioned this pull request Jul 17, 2023
Closed
@cjyar cjyar marked this pull request as ready for review July 17, 2023 21:30
tomhjp
tomhjp approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed report and fix! I pulled this down locally to give it a go and it all works as expected.

@tomhjp tomhjp merged commit adb76bf into hashicorp:main Aug 16, 2023
19 checks passed
@tomhjp tomhjp mentioned this pull request Aug 16, 2023
Merged
@tomhjp tomhjp mentioned this pull request May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhjp tomhjp tomhjp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Injector failure mode prevents Pod deletion
2 participants
@cjyar @tomhjp