Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include namespace in display name with hyphen not colon #38

Closed
davidholsgrove opened this issue Jul 26, 2018 · 1 comment
Closed

Include namespace in display name with hyphen not colon #38

davidholsgrove opened this issue Jul 26, 2018 · 1 comment

Comments

@davidholsgrove
Copy link
Contributor

#31 changed the display name to include the kubernetes namespace (yey!)

When using the Kubernetes auth method to generate MSSQL Database credentials, I now get a username with v-kubernetes-{namespace}: prefix, e.g;

v-kubernetes-testing:v-GENPRD_0XA_LSTN-clie-cFbDNmp9WeGSJAo3hanx-1532477048

previously the equivalent MSSQL username would have been;

v-kubernetes-vault-aut-GENPRD_0XA_LSTN-clie-1qMciGW3fm0jNFAIGMTz-1531203590

Comparing the same credential generated while using the AWS auth method, I get;

v-aws-Role-Lab_ACP-AWS-GENPRD_0XA_LSTN-clie-e7L3UhmmeGCfKCQNwWlr-1532568250

While a colon in a user name is valid for MSSQL, some older applications don't accept this unfortunately.
Can we change the display name to be hyphen separated instead of colon separated, which would be consistent with (at least) AWS Auth?

davidholsgrove added a commit to davidholsgrove/vault-plugin-auth-kubernetes that referenced this issue Jul 26, 2018
@catsby
Copy link
Contributor

catsby commented Nov 8, 2018

Closing b/c #39 was merged 😄

@catsby catsby closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants