Properly handle role.AliasNameSource migration #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set role.AliasNameSource to be the default if both it and its field value are unset instead of returning an error - add tests for the update operation
tomhjp
approved these changes
Feb 7, 2022
Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
benashz
added a commit
that referenced
this pull request
Feb 7, 2022
- set role.AliasNameSource to be the default if both it and its field value are unset instead of returning an error - add tests for the update operation Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
Merged
benashz
deleted the
VAULT-4975/handle-empty-alias-name-source-on-update
branch
benashz
added a commit
that referenced
this pull request
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#133 details an issue where the role configuration cannot be updated when
alias_name_sourceis unset in the request. The result was a validation failure for this field. We can handle this situation be setting the role's alias name source to be default.role.AliasNameSourceto be the default if both it and its fieldvalue are unset instead of returning an error
Design of Change
How was this change implemented?
See above
Related Issues/Pull Requests
Closes #133
Relates to #134
Contributor Checklist
[ ] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR Link
Example
[ ] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[ ] Backwards compatible