Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from circleci to gha #36

Merged
merged 14 commits into from
Mar 20, 2023
Merged

migrate from circleci to gha #36

merged 14 commits into from
Mar 20, 2023

Conversation

Zlaticanin
Copy link
Contributor

@Zlaticanin Zlaticanin commented Mar 20, 2023

This PR migrates this plugin from CircleCI to Github Actions. We do the following:

  • remove the .circleci directory
    • this will cause the CircleCI Pipeline to fail until we disable the project in the CircleCI UI
  • add a .go-version file so that we can reference it from other files
    • this is required by the Run Tests common workflow
  • add a Run Acceptance Tests workflow
    • run the tests with make testacc and
    • build the binary with make dev
  • reuse the common Lint Github Actions Workflows from vault-workflows-common
    • this is a linter for Github actions themselves
    • it will detect problems with our github actions files
  • reuse common "Go Checks" workflow
    • lint code with gofumt
    • ensure go mod is tidy
  • update the Jira Sync action to reuse our common workflow from vault-workflows-common
  • add dependabot
  • add a CHANGELOG.md

@Zlaticanin Zlaticanin marked this pull request as ready for review March 20, 2023 19:43
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Zlaticanin and others added 3 commits March 20, 2023 12:51
Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@Zlaticanin
Copy link
Contributor Author

Thank you so much! @fairclothjm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants