Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource generation target #211

Closed
wants to merge 2 commits into from
Closed

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Apr 25, 2024

make update-resources has been failing for a while now, so we haven't added new APIs in that time.

It seems like Google's discovery/v1 client assumes docs links are in a place where they're not, which caused lots of 404s previously. It's pretty trivial to implement the functionality we need with a plain HTTP client anyway, so I replaced the calls to the API with plain HTTP calls and it's pretty close to working now. The remaining errors are:

errors while generating config: 
unable to add 'bigquery' (version 'v2'): unexpected method formats, get parameters: resource, set parameters: 
unable to add 'dns' (version 'v1beta2'): unable to get schema for setIamPolicy request, could not find policy in schema 'GoogleIamV1SetIamPolicyRequest'
unable to add 'dns' (version 'v1'): unable to get schema for setIamPolicy request, could not find policy in schema 'GoogleIamV1SetIamPolicyRequest'
unable to add 'poly' (version 'v1'), could not find doc - unexpected status code 502
unable to add 'realtimebidding' (version 'v1alpha'), could not find doc - unexpected status code 404

I've also committed the new resources that didn't error (by commenting out the early return for now).

@yzdann
Copy link

yzdann commented May 29, 2024

We are really looking forward to see this out!

@vinay-gopalan
Copy link
Contributor

Closing in favor of #216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants