Fix resource generation target #216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eh-steve
reviewed
Jul 4, 2024
| @@ -53,7 +65,7 @@ func main() { | |||
|
|
|||
| func checkResource(name string, fullPath string, resource *discovery.RestResource, doc *discovery.RestDescription, docMeta *discovery.DirectoryListItems, config iamutil.GeneratedResources) error { | |||
| for rName, child := range resource.Resources { | |||
| checkResource(rName, fullPath+"/"+rName, &child, doc, docMeta, config) | |||
| return checkResource(rName, fullPath+"/"+rName, &child, doc, docMeta, config) | |||
There was a problem hiding this comment.
Suggested change
| return checkResource(rName, fullPath+"/"+rName, &child, doc, docMeta, config) | |
| err := checkResource(rName, fullPath+"/"+rName, &child, doc, docMeta, config) | |
| if err != nil { | |
| return err | |
| } |
|
Hi @vinay-gopalan would you mind merging #218 into this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Builds on #211 and fixes remaining broken resources. This PR also removes the
generatetarget frommake devandmake quickdev(it still persists onmake dev-dynamicif needed). The reason for this is thatmake generatetakes ~5m to complete, and we needn't regenerate resources every time we need a build. If an update to the generated resources is required prior to building, we can always run the following:Related Issues/Pull Requests
PR #211