Truncate ServiceAccount display names longer than 100 characters #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agy
reviewed
May 18, 2020
mdgreenfield
force-pushed
the
sa-display-name-length
branch
from
c52dea7
to
22f9407
Compare
emilymye
previously approved these changes
Jun 24, 2020
This will sha256(displayName[92:]) and concat the first 8 characters of the sha256 hash to the display name. Fixes hashicorp#68
|
@emilymye is this something can get merged? |
calvn
reviewed
Nov 20, 2020
calvn
previously approved these changes
Nov 20, 2020
mdgreenfield
force-pushed
the
sa-display-name-length
branch
from
22f9407
to
22d68fc
Compare
calvn
approved these changes
Nov 24, 2020
calvn
added a commit
that referenced
this pull request
Dec 2, 2020
* Truncate ServiceAccount display names longer than 100 characters This will sha256(displayName[92:]) and concat the first 8 characters of the sha256 hash to the display name. Fixes #68 * Move ServiceAccount display name hash length to constant Co-authored-by: Calvin Leung Huang <cleung2010@gmail.com>
calvn
added a commit
that referenced
this pull request
Dec 3, 2020
#103) * Truncate ServiceAccount display names longer than 100 characters This will sha256(displayName[92:]) and concat the first 8 characters of the sha256 hash to the display name. Fixes #68 * Move ServiceAccount display name hash length to constant Co-authored-by: Calvin Leung Huang <cleung2010@gmail.com> Co-authored-by: Matt Greenfield <matt.greenfield@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will sha256(displayName[92:]) and concat the first 8
characters of the sha256 hash to the display name.
Fixes #68