VaultPKISecret: include the CA chain (sans root) in 'tls.crt' #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the destination type is "kubernetes.io/tls", construct 'tls.crt'
as 'certificate' + 'ca_chain' from the Vault issue response.
('issuing_ca' is used when 'ca_chain' is empty.) Uses the
'remove_roots_from_chain=true' option with Vault to exclude the root
CA from the Vault response.
kschoche
approved these changes
Jun 9, 2023
| @@ -11,7 +11,7 @@ spec: | |||
| vaultAuthRef: vaultauth-sample | |||
| namespace: tenant-1 | |||
| mount: pki | |||
| name: default | |||
| role: default | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the destination type is "kubernetes.io/tls", construct
tls.crtascertificate+ca_chainfrom the Vault issue response. (issuing_cais used whenca_chainis empty.) Uses theremove_roots_from_chain=trueoption with Vault to exclude the root CA from the Vault response. Theremove_roots_from_chainoption was added in Vault 1.12.Tested using the Build Your Own Certificate Authority Vault tutorial and nginx ingress.