Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for spec.refreshAfter and min constraints for HVSA #376

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Add validation for spec.refreshAfter and min constraints for HVSA #376

merged 3 commits into from
Sep 25, 2023

Commits on Sep 25, 2023

  1. Add validation for spec.refreshAfter and min constraints for HVSA 

    Ensure that only support duration string values can be set for
spec.refreshAfter. This change affects VaultStaticSecret and
HCPVaultSecretsApp specs.

In addition to the change above, apply a minimum constraint on the
configured HVSA refreshAfter, with the default value being 30s. This
value can be set from the command line option '-min-refresh-after-hvsa'.

Additional enhancements:
- chart: support extending the controller.manager's args with the new
  extraArgs value.
    @benashz
    benashz committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    db5f234 View commit details
    Browse the repository at this point in the history

  2. Tighten up the refreshAfter regex 

    - drop support for negative durations
    @benashz
    benashz committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c6929b4 View commit details
    Browse the repository at this point in the history

  3. Post-review updates 

    - make some bats Deployment tests more deterministic
    @benashz
    benashz committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a658077 View commit details
    Browse the repository at this point in the history