Add validation for spec.refreshAfter and min constraints for HVSA #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that only support duration string values can be set for spec.refreshAfter. This change affects VaultStaticSecret and HCPVaultSecretsApp specs. In addition to the change above, apply a minimum constraint on the configured HVSA refreshAfter, with the default value being 30s. This value can be set from the command line option '-min-refresh-after-hvsa'. Additional enhancements: - chart: support extending the controller.manager's args with the new extraArgs value.
tvoran
approved these changes
Sep 25, 2023
- drop support for negative durations
- make some bats Deployment tests more deterministic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that only support duration string values can be set for
spec.refreshAfter. This change affects VaultStaticSecret and HCPVaultSecretsApp specs.In addition to the change above, apply a minimum constraint on the configured HVSA refreshAfter, with the default value being 30s. This value can be set from the command line option
-min-refresh-after-hvsa.Additional enhancements: