Client factory: lock by client cache key #686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where a lifetimeWatcher fails to renew the Vault client lease, we want all related VDS instances to be synced. This helps to mitigate the issue where an external revocation of the client token causes the issued secret leases to be revoked. In that case VSO would have no idea that the token has been revoked. The ideal TTL for the client token should be relatively short, e.g. 1m, so as to trigger the lifetimeWatcher earlier. In the future, VSO will be able to subscribe to lease revocation events from Vault. In that case, VSO will be able to perform the sync immediately.
The Client ID is the hash of the Vault secret's accessor. - VDS: trigger sync on Vault Client ID changes
- remove the called back client from the factory's cache to ensure that any of its clones are purged. The next call to Sync() will get a new client back - fix bogus lock handling in the factory's Get()
benashz
force-pushed
the
VAULT-25273/client-factory-lock-by-cacheKey
branch
from
3b9126e
to
b7c785e
Compare
Previously all calls to Get() were serialized using a single lock. This approach does not scale as the number of Vault client grows. With this change locking is done by ClientCacheKey, thereby reducing the overall contention for Vault clients.
benashz
force-pushed
the
VAULT-25273/client-factory-lock-by-cacheKey
branch
from
b7c785e
to
5e230bd
Compare
… into VAULT-25273/client-factory-lock-by-cacheKey
benashz
changed the title
thyton
approved these changes
Apr 22, 2024
Base automatically changed from
VAULT-25273/vds-trigger-reconciliation-on-token-errors
to
main
April 24, 2024 18:33
|
Closing in favor of #716 716 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all calls to Get() were serialized using a single lock. This approach does not scale as the number of Vault client grows. With this change locking is done by ClientCacheKey, thereby reducing the overall contention for Vault clients.