Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 1.9: Fix errors logged on standbys when we try to write versions to storage (#13042) #13076

Merged
merged 1 commit into from Nov 8, 2021
Merged

Backport 1.9: Fix errors logged on standbys when we try to write versions to storage (#13042) #13076

merged 1 commit into from Nov 8, 2021

Conversation

ncabatoff
Copy link
Collaborator

No description provided.

@ncabatoff ncabatoff requested a review from a team November 8, 2021 15:10
@ncabatoff ncabatoff changed the title Fix errors logged on standbys when we try to write versions to storage (#13042) Backport 1.9: Fix errors logged on standbys when we try to write versions to storage (#13042) Nov 8, 2021
@ncabatoff ncabatoff added this to the 1.9 milestone Nov 8, 2021
vishalnayak
vishalnayak reviewed Nov 8, 2021
View reviewed changes
Copy link
Member

@vishalnayak vishalnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hadn't reviewed the PR on main, but took a cursory look at the PR and 1 question stands out in my mind. You might have thought through. This might be just me trying to get a closure.

The main change I believe in this PR was to move the handleVersionTimeStamps from post unseal to standard unseal strategy's unseal function thereby avoiding the warnings on perf standbys. Right? The comment on the PR also mentioned that this should only be done on the active node only. What happens on regular standbys?

@ncabatoff
Copy link
Collaborator Author

The main change I believe in this PR was to move the handleVersionTimeStamps from post unseal to standard unseal strategy's unseal function thereby avoiding the warnings on perf standbys. Right?

Right.

The comment on the PR also mentioned that this should only be done on the active node only. What happens on regular standbys?

Regular standbys never call postUnseal, so they aren't implicated one way or the other.

@ncabatoff ncabatoff merged commit 807d37b into release/1.9.x Nov 8, 2021
@ncabatoff ncabatoff deleted the backport-pr-13042-1.9 branch November 8, 2021 16:43
@thiskevinwang thiskevinwang mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalnayak vishalnayak vishalnayak left review comments

@HridoyRoy HridoyRoy HridoyRoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ncabatoff @vishalnayak @HridoyRoy