Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests on backported docs branches. #13612

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Conversation

ncabatoff
Copy link
Collaborator

Example backport to which this should apply: #13610

@mladlow
Copy link
Collaborator

mladlow commented Jan 10, 2022

Should these edits be in https://github.com/hashicorp/vault/blob/main/.circleci/config/workflows/ci.yml instead? There's a comment at the top of .circleci/config.yml saying that it's autogenerated and not to edit it manually, and there's a section in the ci.yml file like:

  - test-go-race:
      requires:
        - pre-flight-checks
      filters:
        branches:
          # UI and Docs-only branches should skip go tests
          ignore:
            - /^docs\/.*/
            - /^ui\/.*/

…s on inappropriate branches, since otherwise GH's required checks won't be satisfied.
@vercel vercel bot temporarily deployed to Preview – vault January 10, 2022 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook January 10, 2022 17:02 Inactive
@ncabatoff
Copy link
Collaborator Author

Should these edits be in https://github.com/hashicorp/vault/blob/main/.circleci/config/workflows/ci.yml instead? There's a comment at the top of .circleci/config.yml saying that it's autogenerated and not to edit it manually, and there's a section in the ci.yml file like:

  - test-go-race:
      requires:
        - pre-flight-checks
      filters:
        branches:
          # UI and Docs-only branches should skip go tests
          ignore:
            - /^docs\/.*/
            - /^ui\/.*/

Nope, I'm pretty sure that's left over from a previous attempt. That approach doesn't work for required checks like test-go, because then GH never sees the check as completed and the PR is unmergeable. I've removed these to reduce confusion.

Copy link
Collaborator

@mladlow mladlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for cleaning up the old stuff too!

@ncabatoff ncabatoff merged commit edc0025 into main Jan 11, 2022
@ncabatoff ncabatoff deleted the skip-tests-for-docs-backports branch January 11, 2022 14:02
heppu pushed a commit to heppu/vault that referenced this pull request Jan 13, 2022
* Remove unnecessary branch filters; we rely instead on exiting the jobs on inappropriate branches, since otherwise GH's required checks won't be satisfied.
ncabatoff added a commit that referenced this pull request Jan 28, 2022
* Remove unnecessary branch filters; we rely instead on exiting the jobs on inappropriate branches, since otherwise GH's required checks won't be satisfied.
ncabatoff added a commit that referenced this pull request Jan 28, 2022
* Remove unnecessary branch filters; we rely instead on exiting the jobs on inappropriate branches, since otherwise GH's required checks won't be satisfied.
ncabatoff added a commit that referenced this pull request Jan 28, 2022
* Remove unnecessary branch filters; we rely instead on exiting the jobs on inappropriate branches, since otherwise GH's required checks won't be satisfied.
ncabatoff added a commit that referenced this pull request Jan 28, 2022
* Remove unnecessary branch filters; we rely instead on exiting the jobs on inappropriate branches, since otherwise GH's required checks won't be satisfied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants