-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip tests on backported docs branches. #13612
Conversation
Should these edits be in https://github.com/hashicorp/vault/blob/main/.circleci/config/workflows/ci.yml instead? There's a comment at the top of
|
…s on inappropriate branches, since otherwise GH's required checks won't be satisfied.
Nope, I'm pretty sure that's left over from a previous attempt. That approach doesn't work for required checks like test-go, because then GH never sees the check as completed and the PR is unmergeable. I've removed these to reduce confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for cleaning up the old stuff too!
* Remove unnecessary branch filters; we rely instead on exiting the jobs on inappropriate branches, since otherwise GH's required checks won't be satisfied.
* Remove unnecessary branch filters; we rely instead on exiting the jobs on inappropriate branches, since otherwise GH's required checks won't be satisfied.
* Remove unnecessary branch filters; we rely instead on exiting the jobs on inappropriate branches, since otherwise GH's required checks won't be satisfied.
Example backport to which this should apply: #13610