KMSE Capabilities & Phase 1 Cleanup #15143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zofskeez
commented
Apr 22, 2022
zofskeez
commented
- Added capabilities to key and provider models
- Hid toolbar actions when user does not have capability
- Fixed some issues with key-edit component and updated some parts to match designs
- Wired up distribute actions in key and provider views
hashishaw
approved these changes
Apr 25, 2022
| }); | ||
| } catch (error) { | ||
| this.keys = []; | ||
| if (error.httpStatus !== 404) { |
There was a problem hiding this comment.
Gut check: This is because the response is a 404 if the provider has no distributed keys, correct?
There was a problem hiding this comment.
As far as I can remember yes 🙂. That was added in phase 1 but from what I recall if the provider doesn't have any associated keys then we just want to update this.keys rather than surfacing an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.