Update deps for consul-template 0.29.0 #15293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires bumping https://github.com/mitchellh/go-testing-interface. For this new version, we have to create a wrapper to convert the stdlib `testing.TB` interface to the `mitchellh/go-testing-interface` `T` interface, since it uses `Parallel()` now, which is not supported by `testing.TB`. This had to be added to a new package, `benchhelpers`, to avoid a circular dependency in `testhelpers`. We also have to *unbump* https://github.com/armon/go-metrics since updating it breaks our usage of https://github.com/google/go-metrics-stackdriver I verified that the new `pkiCert` template function works with agent injection using annotations like: ```yaml vault.hashicorp.com/agent-inject-secret-sample.crt: "pki/issue/example-dot-com" vault.hashicorp.com/agent-inject-template-sample.crt: | {{ pkiCert "pki/issue/example-dot-com" "common_name=foo.example.com" "ttl=1h" }} ```
added 2 commits
May 4, 2022 13:45
tomhjp
reviewed
May 5, 2022
helper/benchhelpers/benchhelpers.go
Outdated
| import ( | ||
| "testing" | ||
|
|
||
| testing2 "github.com/mitchellh/go-testing-interface" |
There was a problem hiding this comment.
Suggested change
| testing2 "github.com/mitchellh/go-testing-interface" | |
| testinginterface "github.com/mitchellh/go-testing-interface" |
There was a problem hiding this comment.
👍 I initially had something like this, but GoLand "helpfully" changed it when I refactored something. I'll switch it back.
|
When bumping |
tomhjp
approved these changes
May 5, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires bumping https://github.com/mitchellh/go-testing-interface.
For this new version, we have to create a wrapper to convert
the stdlib
testing.TBinterface to themitchellh/go-testing-interfaceTinterface, since it usesParallel()now, which is not supported bytesting.TB. This had to beadded to a new package,
benchhelpers, to avoid a circular dependencyin
testhelpers.We also have to unbump https://github.com/armon/go-metrics since
updating it breaks our usage of
https://github.com/google/go-metrics-stackdriver
I verified that the new
pkiCerttemplate function works with agentinjection using annotations like: