-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autopilot automated upgrades and redundancy zones #15521
Conversation
Since this is primarily an enterprise feature, I'll put the changelog on the ent pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remember to remove the deep:-
annotation in sys_raft before merging.
physical/raft/raft.go
Outdated
@@ -445,6 +445,10 @@ func NewRaftBackend(conf map[string]string, logger log.Logger) (physical.Backend | |||
updateInterval = interval | |||
} | |||
|
|||
if reconcileInterval != 0 && updateInterval != 0 && reconcileInterval < updateInterval { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if they only specify one, but the default for the other is inconsistent with the specified value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the OSS version of https://github.com/hashicorp/vault-enterprise/pull/2816
I haven't looked at this carefully yet, so it's possible I still need to add some stubs for ent specific things.