Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autopilot automated upgrades and redundancy zones #15521

Merged
merged 8 commits into from
May 20, 2022
Merged

Conversation

raskchanky
Copy link
Contributor

This is the OSS version of https://github.com/hashicorp/vault-enterprise/pull/2816

I haven't looked at this carefully yet, so it's possible I still need to add some stubs for ent specific things.

@raskchanky
Copy link
Contributor Author

Since this is primarily an enterprise feature, I'll put the changelog on the ent pr.

api/sys_raft.go Outdated Show resolved Hide resolved
api/sys_raft.go Show resolved Hide resolved
api/sys_raft.go Outdated Show resolved Hide resolved
command/format.go Show resolved Hide resolved
command/format.go Outdated Show resolved Hide resolved
vault/external_tests/raft/raft_test.go Outdated Show resolved Hide resolved
vault/logical_system_raft.go Outdated Show resolved Hide resolved
vault/logical_system_raft.go Show resolved Hide resolved
vault/raft.go Outdated Show resolved Hide resolved
vault/request_forwarding_service.proto Show resolved Hide resolved
Copy link
Collaborator

@ncabatoff ncabatoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to remove the deep:- annotation in sys_raft before merging.

@@ -445,6 +445,10 @@ func NewRaftBackend(conf map[string]string, logger log.Logger) (physical.Backend
updateInterval = interval
}

if reconcileInterval != 0 && updateInterval != 0 && reconcileInterval < updateInterval {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if they only specify one, but the default for the other is inconsistent with the specified value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncabatoff ncabatoff self-requested a review May 20, 2022 20:39
@ncabatoff ncabatoff merged commit de99f93 into main May 20, 2022
@raskchanky raskchanky deleted the autopilot-oss branch May 20, 2022 20:49
Gabrielopesantos pushed a commit to Gabrielopesantos/vault that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants