Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autopilot automated upgrades and redundancy zones #15521

Merged
merged 8 commits into from
May 20, 2022
Merged

Add autopilot automated upgrades and redundancy zones #15521

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9a17255
Add autopilot automated upgrades and redundancy zones
raskchanky May 19, 2022
fe64286
fix a few stubs
raskchanky May 19, 2022
bc0760a
PR feedback
raskchanky May 20, 2022
32cd642
more feedback
raskchanky May 20, 2022
9312f42
add redundancy zone, remove conditional columns
raskchanky May 20, 2022
53289f6
return an error for bad intervals
raskchanky May 20, 2022
75677ea
clarify intervals
raskchanky May 20, 2022
5f65d97
remove deep annotation
raskchanky May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions physical/raft/raft.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,10 @@ func NewRaftBackend(conf map[string]string, logger log.Logger) (physical.Backend
updateInterval = interval
}

if reconcileInterval != 0 && updateInterval != 0 && reconcileInterval < updateInterval {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if they only specify one, but the default for the other is inconsistent with the specified value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

75677ea

return nil, fmt.Errorf("autopilot_reconcile_interval should be larger than autopilot_update_interval")
}

return &RaftBackend{
logger: logger,
fsm: fsm,
Expand Down