Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of docs/vault-k8s: update the service annotation into release/1.8.x #15982

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #15965 to be assessed for backporting due to the inclusion of the label backport/1.8.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


The injector's service annotation is really the vault address to
use, and not just the name of the service.

Also change a couple mentions of "controller" to "injector".

Related to hashicorp/vault-k8s#299


Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 14, 2022

CLA assistant check
All committers have signed the CLA.

@tvoran tvoran force-pushed the backport/docs/VAULT-6571/update-injector-service-annotation/vertically-epic-beetle branch from bb632b4 to 5798e4b Compare June 14, 2022 19:04
@tvoran tvoran marked this pull request as ready for review June 14, 2022 19:05
@tvoran tvoran merged commit a4835d9 into release/1.8.x Jun 14, 2022
@tvoran tvoran deleted the backport/docs/VAULT-6571/update-injector-service-annotation/vertically-epic-beetle branch June 14, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants