Kubernetes Models, Adapters and Serializers #18010

zofskeez · 2022-11-17T16:54:44Z

Adds models, adapters and serializers for Kubernetes secrets engine. In addition, I took a stab at creating a decorator for setting up formFields and formFieldGroups properties on a Model class which leverages the existing expandAttributeMeta and fieldToAttrs utilities.

zofskeez · 2022-11-17T16:56:56Z

ui/app/decorators/model-form-fields.js

+ * propertyNames must be an array of brace expansion supported strings that represent model attr names
+ * groupPropertyNames must be an array of objects where the keys represent the group names and the values are propertyNames


I wanted to use expandAttributeMeta and fieldToAttrs for this first pass but if we wanted to get away from them we could drop the need for passing in the field names and detect them based on the options defined on the attrs which would require even less setup.

Ooh that would be interesting! I like that we're able to control the grouping here, but I have been feeling like there's something missing from the current methods which is that fields which we don't explicitly define don't show up on the form, which negates the benefit of using OpenAPI (the form values are always up to date with the backend requirements).
I think there's already a group field on the OpenAPI x-display-attrs, so we could take advantage of those if we base it off the attributes!
I think for now matching the current behavior is good, and then we can expand/enhance in future iterations.

hashishaw

Looks great! 🤩 Excellent test coverage too

hashishaw · 2022-11-17T17:08:55Z

ui/app/decorators/model-form-fields.js

+ * propertyNames must be an array of brace expansion supported strings that represent model attr names
+ * groupPropertyNames must be an array of objects where the keys represent the group names and the values are propertyNames


Ooh that would be interesting! I like that we're able to control the grouping here, but I have been feeling like there's something missing from the current methods which is that fields which we don't explicitly define don't show up on the form, which negates the benefit of using OpenAPI (the form values are always up to date with the backend requirements).
I think there's already a group field on the OpenAPI x-display-attrs, so we could take advantage of those if we base it off the attributes!
I think for now matching the current behavior is good, and then we can expand/enhance in future iterations.

hashishaw · 2022-11-17T17:09:26Z

ui/app/models/kubernetes/config.js

+import Model, { attr } from '@ember-data/model';
+import { withFormFields } from 'vault/decorators/model-form-fields';
+
+@withFormFields(['kubernetesHost', 'serviceAccountJwt', 'kubernetesCaCert'])


zofskeez · 2022-11-17T18:20:02Z

I think for now matching the current behavior is good, and then we can expand/enhance in future iterations.

That was kind of my thought as well. This gets us moving in the right direction with less setup and we can work towards a zero setup system using either OpenAPI or inferring the fields based on the attr options!

* Ember Engine for Kubernetes Secrets Engine (#17881) * adds in-repo ember engine for kubernetes secrets engine * updates kubernetes engine class name * Kubernetes route plumbing (#17895) * kubernetes route plumbing * adds kubernetes role index route with redirect to details * adds kubernetes as mountable and supported secrets engine (#17891) * adds models, adapters and serializers for kubernetes secrets engine (#18010) * adds mirage factories and handlers for kubernetes (#17943) * Kubernetes Secrets Engine Configuration (#18093) * moves RadioCard component to core addon * adds kubernetes configuration view * fixes tests using RadioCard after label for and input id changes * adds confirm modal when editing kubernetes config * addresses review comments * Kubernetes Configuration View (#18147) * removes configuration edit and index routes * adds kubernetes configuration view * Kubernetes Roles List (#18211) * removes configuration edit and index routes * adds kubernetes configuration view * adds kubernetes secrets engine roles list view * updates role details disabled state to explicitly check for false * VAULT-9863 Kubernetes Overview Page (#18232) * Add overview page view * Add overview page tests * Address feedback to update tests and minor changes * Use template built in helper for conditionally showing num roles * Set up roleOptions in constructor * Set up models in tests and fix minor bug * Kubernetes Secrets Engine Create/Edit Views (#18271) * moves kv-object-editor to core addon * moves json-editor to core addon * adds kubernetes secrets engine create/edit views * updates kubernetes/role adapter test * addresses feedback * fixes issue with overview route showing 404 page (#18303) * Kubernetes Role Details View (#18294) * moves format-duration helper to core addon * adds kubernetes secrets engine role details view * adds tests for role details page component * adds capabilities checks for toolbar actions * fixes list link for secrets in an ember engine (#18313) * Manual Testing: Bug Fixes and Improvements (#18333) * updates overview, configuration and roles components to pass args for individual model properties * bug fixes and improvements * adds top level index route to redirect to overview * VAULT-9877 Kubernetes Credential Generate/View Pages (#18270) * Add credentials route with create and view components * Update mirage response for creds and add ajax post call for creds in adapter * Move credentials create and view into one component * Add test classes * Remove files and update backend property name * Code cleanup and add tests * Put test helper in helper function * Add one more test! * Add code optimizations * Fix model in route and add form * Add onSubmit to form and preventDefault * Fix tests * Update mock data for test to be strong rather than record * adds acceptance tests for kubernetes secrets engine roles (#18360) * VAULT-11862 Kubernetes acceptance tests (#18431) * VAULT-12185 overview acceptance tests * VAULT-12298 credentials acceptance tests * VAULT-12186 configuration acceptance tests * VAULT-12127 Refactor breadcrumbs to use breadcrumb component (#18489) * VAULT-12127 Refactor breadcrumbs to use Page::Breadcrumbs component * Fix failing tests by adding breadcrumbs properties * VAULT-12166 add jsdocs to kubernetes secrets engine pages (#18509) * fixes incorrect merge conflict resolution * updates kubernetes check env vars endpoint (#18588) * hides kubernetes ca cert field if not defined in configuration view * fixes loading substate handling issue (#18592) * adds changelog entry Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com>

* Ember Engine for Kubernetes Secrets Engine (hashicorp#17881) * adds in-repo ember engine for kubernetes secrets engine * updates kubernetes engine class name * Kubernetes route plumbing (hashicorp#17895) * kubernetes route plumbing * adds kubernetes role index route with redirect to details * adds kubernetes as mountable and supported secrets engine (hashicorp#17891) * adds models, adapters and serializers for kubernetes secrets engine (hashicorp#18010) * adds mirage factories and handlers for kubernetes (hashicorp#17943) * Kubernetes Secrets Engine Configuration (hashicorp#18093) * moves RadioCard component to core addon * adds kubernetes configuration view * fixes tests using RadioCard after label for and input id changes * adds confirm modal when editing kubernetes config * addresses review comments * Kubernetes Configuration View (hashicorp#18147) * removes configuration edit and index routes * adds kubernetes configuration view * Kubernetes Roles List (hashicorp#18211) * removes configuration edit and index routes * adds kubernetes configuration view * adds kubernetes secrets engine roles list view * updates role details disabled state to explicitly check for false * VAULT-9863 Kubernetes Overview Page (hashicorp#18232) * Add overview page view * Add overview page tests * Address feedback to update tests and minor changes * Use template built in helper for conditionally showing num roles * Set up roleOptions in constructor * Set up models in tests and fix minor bug * Kubernetes Secrets Engine Create/Edit Views (hashicorp#18271) * moves kv-object-editor to core addon * moves json-editor to core addon * adds kubernetes secrets engine create/edit views * updates kubernetes/role adapter test * addresses feedback * fixes issue with overview route showing 404 page (hashicorp#18303) * Kubernetes Role Details View (hashicorp#18294) * moves format-duration helper to core addon * adds kubernetes secrets engine role details view * adds tests for role details page component * adds capabilities checks for toolbar actions * fixes list link for secrets in an ember engine (hashicorp#18313) * Manual Testing: Bug Fixes and Improvements (hashicorp#18333) * updates overview, configuration and roles components to pass args for individual model properties * bug fixes and improvements * adds top level index route to redirect to overview * VAULT-9877 Kubernetes Credential Generate/View Pages (hashicorp#18270) * Add credentials route with create and view components * Update mirage response for creds and add ajax post call for creds in adapter * Move credentials create and view into one component * Add test classes * Remove files and update backend property name * Code cleanup and add tests * Put test helper in helper function * Add one more test! * Add code optimizations * Fix model in route and add form * Add onSubmit to form and preventDefault * Fix tests * Update mock data for test to be strong rather than record * adds acceptance tests for kubernetes secrets engine roles (hashicorp#18360) * VAULT-11862 Kubernetes acceptance tests (hashicorp#18431) * VAULT-12185 overview acceptance tests * VAULT-12298 credentials acceptance tests * VAULT-12186 configuration acceptance tests * VAULT-12127 Refactor breadcrumbs to use breadcrumb component (hashicorp#18489) * VAULT-12127 Refactor breadcrumbs to use Page::Breadcrumbs component * Fix failing tests by adding breadcrumbs properties * VAULT-12166 add jsdocs to kubernetes secrets engine pages (hashicorp#18509) * fixes incorrect merge conflict resolution * updates kubernetes check env vars endpoint (hashicorp#18588) * hides kubernetes ca cert field if not defined in configuration view * fixes loading substate handling issue (hashicorp#18592) * adds changelog entry Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com>

adds models, adapters and serializers for kubernetes secrets engine

a398580

zofskeez added the ui label Nov 17, 2022

zofskeez commented Nov 17, 2022

View reviewed changes

zofskeez added this to the 1.13.0-rc1 milestone Nov 17, 2022

hashishaw approved these changes Nov 17, 2022

View reviewed changes

zofskeez merged commit 39e67ff into ui/kubernetes-secrets-engine Nov 17, 2022

zofskeez deleted the ui/VAULT-11521/k8s-models branch November 17, 2022 18:21

zofskeez mentioned this pull request Nov 23, 2022

Sideport Model Form Fields Decorator #18103

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kubernetes Models, Adapters and Serializers #18010

Kubernetes Models, Adapters and Serializers #18010

zofskeez commented Nov 17, 2022

zofskeez Nov 17, 2022 •

edited

hashishaw Nov 17, 2022

hashishaw left a comment

hashishaw Nov 17, 2022

hashishaw Nov 17, 2022

zofskeez commented Nov 17, 2022

		* propertyNames must be an array of brace expansion supported strings that represent model attr names
		* groupPropertyNames must be an array of objects where the keys represent the group names and the values are propertyNames

Kubernetes Models, Adapters and Serializers #18010

Kubernetes Models, Adapters and Serializers #18010

Conversation

zofskeez commented Nov 17, 2022

zofskeez Nov 17, 2022 • edited

Choose a reason for hiding this comment

hashishaw Nov 17, 2022

Choose a reason for hiding this comment

hashishaw left a comment

Choose a reason for hiding this comment

hashishaw Nov 17, 2022

Choose a reason for hiding this comment

hashishaw Nov 17, 2022

Choose a reason for hiding this comment

zofskeez commented Nov 17, 2022

zofskeez Nov 17, 2022 •

edited