Manual Testing: Bug Fixes and Improvements #18333

zofskeez · 2022-12-13T16:51:15Z

During manual testing some bugs were revealed and general improvements were made:

link in ConfigCta component was pointed to incorrect route
added catch to return empty array in roles model hook
delete action in roles list menu was not working
in role create/edit view the generated role rules were not saving
updated overview, configuration and roles page components to accept args for individual model properties
fixes page::role::details test broken in previous PR
adds more test coverage for generated role rules
adds top level index route that redirects to overview

… individual model properties

zofskeez · 2022-12-13T16:55:13Z

ui/lib/kubernetes/addon/components/page/roles.js

-  @task
-  @waitFor
-  *onDelete(model) {
+  @action
+  async onDelete(model) {
    try {
-      yield model.destroyRecord();
-      this.args.model.roles.removeObject(model);
+      const message = `Successfully deleted role ${model.name}`;
+      await model.destroyRecord();
+      this.args.roles.removeObject(model);
+      this.flashMessages.success(message);


Since there is no disabled or loading state for this action there is no real advantage of using a concurrency task here that I can see.

hashishaw · 2022-12-13T17:55:53Z

ui/lib/kubernetes/addon/routes/index.js

+  @service router;
+
+  redirect() {
+    this.router.transitionTo('vault.cluster.secrets.backend.kubernetes.overview');


hashishaw

LGTM! I like the pattern of passing in specific items from the model rather than grabbing everything off @model within the component

kiannaquach · 2022-12-13T18:04:34Z

ui/lib/kubernetes/addon/templates/configuration.hbs

I'm a big fan of this pattern! It makes it easier to access these properties in the component template :) Thanks for fixing them in the templates!!

zofskeez · 2022-12-13T18:07:13Z

TM! I like the pattern of passing in specific items from the model rather than grabbing everything off @model within the component

I'm a big fan of this pattern! It makes it easier to access these properties in the component template :)

I'd say this is the typical pattern and I'm not sure why I was passing the route model to begin with! Only occurred to me after that something looked off 😁

kiannaquach · 2022-12-13T18:07:50Z

ui/tests/integration/components/kubernetes/page/configuration-test.js

+    this.renderComponent = () => {
+      return render(hbs`<Page::Configuration @backend={{this.backend}} @config={{this.config}} />`, {
+        owner: this.engine,
+      });


* Ember Engine for Kubernetes Secrets Engine (#17881) * adds in-repo ember engine for kubernetes secrets engine * updates kubernetes engine class name * Kubernetes route plumbing (#17895) * kubernetes route plumbing * adds kubernetes role index route with redirect to details * adds kubernetes as mountable and supported secrets engine (#17891) * adds models, adapters and serializers for kubernetes secrets engine (#18010) * adds mirage factories and handlers for kubernetes (#17943) * Kubernetes Secrets Engine Configuration (#18093) * moves RadioCard component to core addon * adds kubernetes configuration view * fixes tests using RadioCard after label for and input id changes * adds confirm modal when editing kubernetes config * addresses review comments * Kubernetes Configuration View (#18147) * removes configuration edit and index routes * adds kubernetes configuration view * Kubernetes Roles List (#18211) * removes configuration edit and index routes * adds kubernetes configuration view * adds kubernetes secrets engine roles list view * updates role details disabled state to explicitly check for false * VAULT-9863 Kubernetes Overview Page (#18232) * Add overview page view * Add overview page tests * Address feedback to update tests and minor changes * Use template built in helper for conditionally showing num roles * Set up roleOptions in constructor * Set up models in tests and fix minor bug * Kubernetes Secrets Engine Create/Edit Views (#18271) * moves kv-object-editor to core addon * moves json-editor to core addon * adds kubernetes secrets engine create/edit views * updates kubernetes/role adapter test * addresses feedback * fixes issue with overview route showing 404 page (#18303) * Kubernetes Role Details View (#18294) * moves format-duration helper to core addon * adds kubernetes secrets engine role details view * adds tests for role details page component * adds capabilities checks for toolbar actions * fixes list link for secrets in an ember engine (#18313) * Manual Testing: Bug Fixes and Improvements (#18333) * updates overview, configuration and roles components to pass args for individual model properties * bug fixes and improvements * adds top level index route to redirect to overview * VAULT-9877 Kubernetes Credential Generate/View Pages (#18270) * Add credentials route with create and view components * Update mirage response for creds and add ajax post call for creds in adapter * Move credentials create and view into one component * Add test classes * Remove files and update backend property name * Code cleanup and add tests * Put test helper in helper function * Add one more test! * Add code optimizations * Fix model in route and add form * Add onSubmit to form and preventDefault * Fix tests * Update mock data for test to be strong rather than record * adds acceptance tests for kubernetes secrets engine roles (#18360) * VAULT-11862 Kubernetes acceptance tests (#18431) * VAULT-12185 overview acceptance tests * VAULT-12298 credentials acceptance tests * VAULT-12186 configuration acceptance tests * VAULT-12127 Refactor breadcrumbs to use breadcrumb component (#18489) * VAULT-12127 Refactor breadcrumbs to use Page::Breadcrumbs component * Fix failing tests by adding breadcrumbs properties * VAULT-12166 add jsdocs to kubernetes secrets engine pages (#18509) * fixes incorrect merge conflict resolution * updates kubernetes check env vars endpoint (#18588) * hides kubernetes ca cert field if not defined in configuration view * fixes loading substate handling issue (#18592) * adds changelog entry Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com>

* Ember Engine for Kubernetes Secrets Engine (hashicorp#17881) * adds in-repo ember engine for kubernetes secrets engine * updates kubernetes engine class name * Kubernetes route plumbing (hashicorp#17895) * kubernetes route plumbing * adds kubernetes role index route with redirect to details * adds kubernetes as mountable and supported secrets engine (hashicorp#17891) * adds models, adapters and serializers for kubernetes secrets engine (hashicorp#18010) * adds mirage factories and handlers for kubernetes (hashicorp#17943) * Kubernetes Secrets Engine Configuration (hashicorp#18093) * moves RadioCard component to core addon * adds kubernetes configuration view * fixes tests using RadioCard after label for and input id changes * adds confirm modal when editing kubernetes config * addresses review comments * Kubernetes Configuration View (hashicorp#18147) * removes configuration edit and index routes * adds kubernetes configuration view * Kubernetes Roles List (hashicorp#18211) * removes configuration edit and index routes * adds kubernetes configuration view * adds kubernetes secrets engine roles list view * updates role details disabled state to explicitly check for false * VAULT-9863 Kubernetes Overview Page (hashicorp#18232) * Add overview page view * Add overview page tests * Address feedback to update tests and minor changes * Use template built in helper for conditionally showing num roles * Set up roleOptions in constructor * Set up models in tests and fix minor bug * Kubernetes Secrets Engine Create/Edit Views (hashicorp#18271) * moves kv-object-editor to core addon * moves json-editor to core addon * adds kubernetes secrets engine create/edit views * updates kubernetes/role adapter test * addresses feedback * fixes issue with overview route showing 404 page (hashicorp#18303) * Kubernetes Role Details View (hashicorp#18294) * moves format-duration helper to core addon * adds kubernetes secrets engine role details view * adds tests for role details page component * adds capabilities checks for toolbar actions * fixes list link for secrets in an ember engine (hashicorp#18313) * Manual Testing: Bug Fixes and Improvements (hashicorp#18333) * updates overview, configuration and roles components to pass args for individual model properties * bug fixes and improvements * adds top level index route to redirect to overview * VAULT-9877 Kubernetes Credential Generate/View Pages (hashicorp#18270) * Add credentials route with create and view components * Update mirage response for creds and add ajax post call for creds in adapter * Move credentials create and view into one component * Add test classes * Remove files and update backend property name * Code cleanup and add tests * Put test helper in helper function * Add one more test! * Add code optimizations * Fix model in route and add form * Add onSubmit to form and preventDefault * Fix tests * Update mock data for test to be strong rather than record * adds acceptance tests for kubernetes secrets engine roles (hashicorp#18360) * VAULT-11862 Kubernetes acceptance tests (hashicorp#18431) * VAULT-12185 overview acceptance tests * VAULT-12298 credentials acceptance tests * VAULT-12186 configuration acceptance tests * VAULT-12127 Refactor breadcrumbs to use breadcrumb component (hashicorp#18489) * VAULT-12127 Refactor breadcrumbs to use Page::Breadcrumbs component * Fix failing tests by adding breadcrumbs properties * VAULT-12166 add jsdocs to kubernetes secrets engine pages (hashicorp#18509) * fixes incorrect merge conflict resolution * updates kubernetes check env vars endpoint (hashicorp#18588) * hides kubernetes ca cert field if not defined in configuration view * fixes loading substate handling issue (hashicorp#18592) * adds changelog entry Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com>

zofskeez added 2 commits December 13, 2022 09:44

updates overview, configuration and roles components to pass args for…

32b0c30

… individual model properties

bug fixes and improvements

5d813d5

zofskeez added the ui label Dec 13, 2022

zofskeez added this to the 1.13.0-rc1 milestone Dec 13, 2022

zofskeez commented Dec 13, 2022

View reviewed changes

adds top level index route to redirect to overview

eb9ffcf

hashishaw reviewed Dec 13, 2022

View reviewed changes

hashishaw approved these changes Dec 13, 2022

View reviewed changes

kiannaquach reviewed Dec 13, 2022

View reviewed changes

zofskeez merged commit 4e46c2e into ui/kubernetes-secrets-engine Dec 13, 2022

zofskeez deleted the ui/VAULT-12086/manual-testing-bugs branch December 13, 2022 18:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manual Testing: Bug Fixes and Improvements #18333

Manual Testing: Bug Fixes and Improvements #18333

zofskeez commented Dec 13, 2022 •

edited

zofskeez Dec 13, 2022

hashishaw Dec 13, 2022

hashishaw left a comment

kiannaquach Dec 13, 2022 •

edited

zofskeez commented Dec 13, 2022

kiannaquach Dec 13, 2022

Manual Testing: Bug Fixes and Improvements #18333

Manual Testing: Bug Fixes and Improvements #18333

Conversation

zofskeez commented Dec 13, 2022 • edited

zofskeez Dec 13, 2022

Choose a reason for hiding this comment

hashishaw Dec 13, 2022

Choose a reason for hiding this comment

hashishaw left a comment

Choose a reason for hiding this comment

kiannaquach Dec 13, 2022 • edited

Choose a reason for hiding this comment

zofskeez commented Dec 13, 2022

kiannaquach Dec 13, 2022

Choose a reason for hiding this comment

zofskeez commented Dec 13, 2022 •

edited

kiannaquach Dec 13, 2022 •

edited