Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: restrict node engines to <= 16.x #18077

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

BRKalow
Copy link
Contributor

@BRKalow BRKalow commented Nov 22, 2022

Restrict the node engines declaration for the website so it only uses up to 16.x.

Copy link
Contributor

@thiskevinwang thiskevinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: adding this due to new Node 18 availability

Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@BRKalow
Copy link
Contributor Author

BRKalow commented Nov 22, 2022

@ccapurso I'll need you to merge this when it's ready as I don't have permissions 🙏

@ccapurso
Copy link
Contributor

@BRKalow, enabling auto-merge which will go through unless main changes in the process.

@ccapurso ccapurso merged commit 01b6b1f into main Nov 22, 2022
@ccapurso ccapurso deleted the brk.chore/restrict-node-engines branch November 22, 2022 15:43
jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants