ui: add input as event for text form field #18563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
commented
Jan 3, 2023
| onchange={{this.onChangeWithEvent}} | ||
| onkeyup={{this.handleKeyUp}} | ||
| {{on "input" this.onChangeWithEvent}} | ||
| {{on "change" this.onChangeWithEvent}} |
There was a problem hiding this comment.
both of these other event listeners are redundant here, now that "input" has been added, right?
There was a problem hiding this comment.
From MDN:
The change event is fired for
<input>,<select>, and<textarea>elements when the user modifies the element's value. Unlike the input event, the change event is not necessarily fired for each alteration to an element's value.
It looks like they are mostly interchangeable, and we should favor change events because historically the input event isn't always implemented to spec.
There was a problem hiding this comment.
Yeah that's what I read from the docs, but when it was just on change the model wasn't updating properly 🤔
hashishaw
approved these changes
Jan 4, 2023
joshbrand
pushed a commit
that referenced
this pull request
Jan 11, 2023
* add input as event for form field * fix event typo, lowercase u
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* add input as event for form field * fix event typo, lowercase u
dhuckins
pushed a commit
that referenced
this pull request
Jan 19, 2023
* add input as event for form field * fix event typo, lowercase u
dhuckins
pushed a commit
that referenced
this pull request
Jan 19, 2023
* add input as event for form field * fix event typo, lowercase u
AnPucel
pushed a commit
that referenced
this pull request
Jan 25, 2023
* add input as event for form field * fix event typo, lowercase u
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* add input as event for form field * fix event typo, lowercase u
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
* add input as event for form field * fix event typo, lowercase u
This was referenced Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While smoke testing the pki key workflow, I noticed the model name wasn't updating as the text changed in the input field.