VAULT-9883: Agent Reloadable Config #18638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteski22
added
enhancement
core
ncabatoff
reviewed
Jan 10, 2023
VioletHynes
reviewed
Jan 10, 2023
VioletHynes
reviewed
Jan 10, 2023
VioletHynes
reviewed
Jan 10, 2023
VioletHynes
reviewed
Jan 10, 2023
VioletHynes
reviewed
Jan 10, 2023
VioletHynes
reviewed
Jan 10, 2023
VioletHynes
reviewed
Jan 10, 2023
ncabatoff
reviewed
Jan 10, 2023
ncabatoff
reviewed
Jan 10, 2023
ncabatoff
reviewed
Jan 10, 2023
Co-authored-by: Nick Cabatoff <ncabatoff@hashicorp.com>
…corp/vault into VAULT-9883-agent-reloadable-config
VioletHynes
approved these changes
Jan 10, 2023
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* Update command/agent.go * Attempt to only reload log level and certs * Mimicked 'server' test for cert reload in 'agent' Co-authored-by: Nick Cabatoff <ncabatoff@hashicorp.com> Left out the `c.config` tweak that meant changes to lots of lines of code within the `Run` function of Agent command. :)
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* Update command/agent.go * Attempt to only reload log level and certs * Mimicked 'server' test for cert reload in 'agent' Co-authored-by: Nick Cabatoff <ncabatoff@hashicorp.com> Left out the `c.config` tweak that meant changes to lots of lines of code within the `Run` function of Agent command. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows Vault
agentto receive and react to aSIGHUPsignal to reload parts of its configuration without requiring a restart.This should bring some level of parity between Vault
serverandagentcommands, asserveralready supports processing ofSIGHUP.Initially the two things which can be reloaded are:
SIGHUPwill cause Vault Agent to re-process config file(s) and apply log level from config.Note: this means that CLI flags and/or environment variables for config values which are reloaded, will be ignored in favour of the configuration file. This is in opposition to the order of precedence usually applied:
cli flag > env var > config fileResolves: #8216