Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for docker testclusters #20247

Merged
merged 66 commits into from
Apr 24, 2023
Merged

Add support for docker testclusters #20247

merged 66 commits into from
Apr 24, 2023

Commits on Apr 18, 2023

  1. First steps towards docker-based tests: tests using vault binary in -… 

    …dev or -dev-three-node modes.
    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    7d6da7f View commit details
    Browse the repository at this point in the history

  2. Declare setup dep.

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    a7a6604 View commit details
    Browse the repository at this point in the history

  3. Try to build vault the way test-ui is doing it.

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    115aa3f View commit details
    Browse the repository at this point in the history

  4. Fix missing runs-on for build-vault.

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    194965c View commit details
    Browse the repository at this point in the history

  5. Add missing fromJSON

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    4cabf20 View commit details
    Browse the repository at this point in the history

  6. Add checkout, setup-go to build-vault

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    5f54174 View commit details
    Browse the repository at this point in the history

  7. Propagate dev vault binary to test-go

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    bc85429 View commit details
    Browse the repository at this point in the history

  8. Improve vault dev binary handling

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    8a8aa9e View commit details
    Browse the repository at this point in the history

  9. Move vault dev binary building into test-go

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    4e3f948 View commit details
    Browse the repository at this point in the history

  10. Attempt to only run exec tests (and build vault binary) for the simpl… 

    …e go test case.
    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    0bce1b0 View commit details
    Browse the repository at this point in the history

  11. Attempt to only run exec tests (and build vault binary) for the simpl… 

    …e go test case, take 2
    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    027da9f View commit details
    Browse the repository at this point in the history

  12. Use inputs instead of env

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    2f936f1 View commit details
    Browse the repository at this point in the history

  13. Fix syntax error

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    f3bfb40 View commit details
    Browse the repository at this point in the history

  14. Fix syntax error, again

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    0815d23 View commit details
    Browse the repository at this point in the history

  15. Fix typo

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    f99e734 View commit details
    Browse the repository at this point in the history

  16. Fix shell bug

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    65b04cd View commit details
    Browse the repository at this point in the history

  17. Add test godoc

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    f4c8c3e View commit details
    Browse the repository at this point in the history

  18. Fix JSON syntax

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    f8289b3 View commit details
    Browse the repository at this point in the history

  19. Add default to extra-flags input

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    d8e4330 View commit details
    Browse the repository at this point in the history

  20. Add parens around negated expr to workaround a yaml issue.

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    157b0fb View commit details
    Browse the repository at this point in the history

  21. Exclude fips case as well

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    516c3d0 View commit details
    Browse the repository at this point in the history

  22. We can't actually skip the build-vault job, since test-go depends on … 

    …it, so instead skip each step. Yuck.
    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    f531fec View commit details
    Browse the repository at this point in the history

  23. Improve CL and godoc.

    @ncabatoff
    ncabatoff committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    bd4f3da View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Add support for docker testclusters and server option -dev-three-dock… 

    …er-node. All that's missing is for the "current" vault binary to be used.
    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    69d937c View commit details
    Browse the repository at this point in the history

  2. Allow docker testclusters to build an image dynamically, shoving in t… 

    …he current vault binary.
    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    b2b1eee View commit details
    Browse the repository at this point in the history

  3. Pull out dev-three-docker-node stuff, maybe it doesn't belong here, c… 

    …an always put it in its own PR if we change our mind.
    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    37c7e56 View commit details
    Browse the repository at this point in the history

  4. Minor cleanup. Also attempted to ensure that I didn't introduce unnec… 

    …essary go.mod changes by reverting to the parent branch version's, then doing go mod tidy.
    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    359972d View commit details
    Browse the repository at this point in the history

  5. Review feedback.

    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    fa42073 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'test-exec-vault-dev' into test-docker-vault

    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    e948cb9 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into test-exec-vault-dev

    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    4f0f838 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'test-exec-vault-dev' into test-docker-vault

    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    a524046 View commit details
    Browse the repository at this point in the history

  9. Update our hack to pin etcd

    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    ade6602 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into test-exec-vault-dev

    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    7e1658f View commit details
    Browse the repository at this point in the history

  11. Merge branch 'test-exec-vault-dev' into test-docker-vault 

    # Conflicts:
#	go.mod
#	go.sum
    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    6a899b7 View commit details
    Browse the repository at this point in the history

  12. go mod tidy

    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    fb259e1 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into test-exec-vault-dev 

    # Conflicts:
#	api/client.go
    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    3bf9d7d View commit details
    Browse the repository at this point in the history

  14. Use api v1.9.1

    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    1f60687 View commit details
    Browse the repository at this point in the history

  15. Remove replace directive and tidy.

    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    a7841ed View commit details
    Browse the repository at this point in the history

  16. Something went wrong in my previous tidy attempt. Let's try again.

    @ncabatoff
    ncabatoff committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    359c691 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Remove sdk test that has inappropriate dependency on vault module.

    @ncabatoff
    ncabatoff committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    82d508f View commit details
    Browse the repository at this point in the history

  2. go mod tidy

    @ncabatoff
    ncabatoff committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    5fb9d77 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'test-exec-vault-dev' into test-docker-vault 

    # Conflicts:
#	go.sum
#	sdk/go.mod
#	sdk/go.sum
    @ncabatoff
    ncabatoff committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    648d7f4 View commit details
    Browse the repository at this point in the history

  4. go mod tidy

    @ncabatoff
    ncabatoff committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    74b75ef View commit details
    Browse the repository at this point in the history

  5. Improve logging, add support for base listen address so that multiple… 

    … tests can run in parallel (though user must ensure different test clusters get different addresses.)
    @ncabatoff
    ncabatoff committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    54ab7ad View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into test-exec-vault-dev

    @ncabatoff
    ncabatoff committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    d93a05d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'test-exec-vault-dev' into test-docker-vault

    @ncabatoff
    ncabatoff committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    e98fd62 View commit details
    Browse the repository at this point in the history

  8. Add pwd to see why we're not finding bin/vault.

    @ncabatoff
    ncabatoff committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    74bcb96 View commit details
    Browse the repository at this point in the history

  9. Add more instrumentation

    @ncabatoff
    ncabatoff committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    7e726a1 View commit details
    Browse the repository at this point in the history

  10. Fix path for artifact download

    @ncabatoff
    ncabatoff committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ae60a37 View commit details
    Browse the repository at this point in the history

  11. Bit of cleanup, and some reworking of how we scrub timestamps. Still … 

    …looking at how to adapt the sol'n from the exec case.
    @ncabatoff
    ncabatoff committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    d7b3c54 View commit details
    Browse the repository at this point in the history

  12. Remove instrumentation, fix VAULT_BINARY setting.

    @ncabatoff
    ncabatoff committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    0682d6b View commit details
    Browse the repository at this point in the history

  13. Merge branch 'test-exec-vault-dev' into test-docker-vault

    @ncabatoff
    ncabatoff committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    110c661 View commit details
    Browse the repository at this point in the history

  14. Got the JSON log approach from exec working with docker. Still a bit … 

    …of cleanup needed but the concept is sound.
    @ncabatoff
    ncabatoff committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6c9bbfa View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Remove hardcoded vault image tag.

    @ncabatoff
    ncabatoff committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    de14905 View commit details
    Browse the repository at this point in the history

  2. Make APIClient always return a clone

    @ncabatoff
    ncabatoff committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    cf69d45 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Fix support on Podman service (#20300) 

    When using the podman service runner (creating a socket equivalent to
Docker's), tests fail with a nil pointer exception since the bridge
network is named "podman", not "bridge".

Allow single networked containers and use whatever name the container
runner assigns to it.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    cb6be71 View commit details
    Browse the repository at this point in the history

  2. Fix APIClient: clone doesn't copy tokens.

    @ncabatoff
    ncabatoff committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    89117bb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into test-exec-vault-dev

    @ncabatoff
    ncabatoff committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    e9c6a17 View commit details
    Browse the repository at this point in the history

  4. Revisit client cloning.

    @ncabatoff
    ncabatoff committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    cdc75c3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'test-exec-vault-dev' into test-docker-vault

    @ncabatoff
    ncabatoff committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    cdf3dd5 View commit details
    Browse the repository at this point in the history

  6. Follow the exec cluster's lead in how to manage vault clients.

    @ncabatoff
    ncabatoff committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    4f2f99e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into test-docker-vault 

    # Conflicts:
#	go.sum
#	sdk/go.mod
#	sdk/go.sum
    @ncabatoff
    ncabatoff committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    0b51ffd View commit details
    Browse the repository at this point in the history

  8. Merge main, go tidy, document some weirdness.

    @ncabatoff
    ncabatoff committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    a6dd92a View commit details
    Browse the repository at this point in the history

  9. Review feedback.

    @ncabatoff
    ncabatoff committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    bbefe63 View commit details
    Browse the repository at this point in the history

  10. export Container field

    @ncabatoff
    ncabatoff committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    5cd4a84 View commit details
    Browse the repository at this point in the history

  11. Add godoc

    @ncabatoff
    ncabatoff committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    9e4deb3 View commit details
    Browse the repository at this point in the history