TakesArbitraryInput fixes #22027
Merged
TakesArbitraryInput fixes #22027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the OpenAPI generation code to render TakesArbitraryInput appropriately. Mark the cubbyhole write operation as TakesArbitraryInput. Contributes to fixing hashicorp/vault-client-go#201. We will also need hashicorp/vault-plugin-secrets-kv#114 merged and a new version of that plugin brought into Vault.
|
This is a tiny part of general trends toward making the OpenAPI better, so I'm inclined to say just |
averche
pushed a commit
to hashicorp/vault-client-go
that referenced
this pull request
Jul 23, 2023
Contributes to fixing #201 These template changes make no difference to the code right now, but combined with the incoming OpenAPI changes in hashicorp/vault#22027 and hashicorp/vault-plugin-secrets-kv#114 will effect the fix.
#22028 opened to bring that into Vault. |
averche
approved these changes
Jul 24, 2023
This was referenced Jul 25, 2023
averche
pushed a commit
to hashicorp/vault-client-go
that referenced
this pull request
Jul 25, 2023
This includes the results of: * hashicorp/vault#21949 * hashicorp/vault#21942 * hashicorp/vault#22027 The general direction of change is pretty positive, but in reviewing the generated diffs, I have spotted an issue: we are now generating correct parameters for query parameters... but those query parameters are being handled as individual function parameters... which are generated in the order listed in the OpenAPI spec... which is dependent on random Go hash iteration ordering. Ugh. Oh well, let's catch up with latest developments in the Vault repo for now, and I'll go put in a new PR to at least sort the parameters alphabetically. Longer term, this is probably going to push us in the direction of excluding the GET version of APIs with equivalent GET and POST versions from the generated libraries.
averche
pushed a commit
to hashicorp/vault-client-dotnet
that referenced
this pull request
Jul 25, 2023
…150) * Sync OpenAPI; Multiple parameter correctness changes This includes the results of: * hashicorp/vault#21949 * hashicorp/vault#21942 * hashicorp/vault#22027 The general direction of change is pretty positive, but in reviewing the generated diffs, I have spotted an issue: we are now generating correct parameters for query parameters... but those query parameters are being handled as individual function parameters... which are generated in the order listed in the OpenAPI spec... which is dependent on random Go hash iteration ordering. Ugh. Oh well, let's catch up with latest developments in the Vault repo for now, and I'll go put in a new PR to at least sort the parameters alphabetically. Longer term, this is probably going to push us in the direction of excluding the GET version of APIs with equivalent GET and POST versions from the generated libraries. * Update the templates with a missing using directive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the OpenAPI generation code to render TakesArbitraryInput
appropriately.
Mark the cubbyhole write operation as TakesArbitraryInput.
Contributes to fixing
hashicorp/vault-client-go#201.
We will also need
hashicorp/vault-plugin-secrets-kv#114 merged and
a new version of that plugin brought into Vault.