Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of KV secrets engine plugin #22028

Closed
wants to merge 1 commit into from

Conversation

maxb
Copy link
Contributor

@maxb maxb commented Jul 23, 2023

Only change is to set the TakesArbitraryInput metadata on the KV v1
endpoint, which we need to fix hashicorp/vault-client-go#201.

Only change is to set the `TakesArbitraryInput` metadata on the KV v1
endpoint, which we need to fix hashicorp/vault-client-go#201.
@maxb maxb mentioned this pull request Jul 23, 2023
@averche
Copy link
Contributor

averche commented Jul 24, 2023

Hi @maxb! I believe we would need to release each affected plugin first and link against the released version. I'll try to take care of it this week :)

In the meantime, If you want to regenerate the latest openapi.json for vault-client-go / vault-client-dotnet, feel free to just use the replace directive in your local vault's go.mod (or go.work):

replace github.com/hashicorp/vault-plugin-secrets-kv => /path/to/your/vault-plugin-secrets-kv

Since the two client libraries are still in BETA and there is no established CI workflow, the openapi.json in the libraries does not need to strictly match the one generated in the main branch of Vault.

@maxb
Copy link
Contributor Author

maxb commented Jul 25, 2023

I believe we would need to release each affected plugin first and link against the released version.

Right, that would be one way to do it. Really it comes down to HashiCorp internal policy and how you want to manage such things:

  • You could decide that it's only acceptable to use released tagged versions of plugins in the Vault main branch

  • Or you could decide pseudo-versions are fine in the middle of the Vault development cycle, and you'll use the batch of plugin releases that usually seem to occur when getting ready to fork a new Vault release branch to set any pseudo-versions used during development back to real tags

Either way, if you're happy for vault-client-go/dotnet to be updated with locally generated OpenAPI specs based on future plugin versions yet to be merged, there's no hurry to get these versions increased in the short term.

@maxb
Copy link
Contributor Author

maxb commented Jul 25, 2023

I'll try to take care of it this week :)

Maybe hold off a little longer - I'm now up to 4 open PRs against the KV plugin :-) (Not all OpenAPI-related, I hasten to add.)

@maxb maxb marked this pull request as draft July 25, 2023 12:03
@maxb maxb closed this Jul 26, 2023
@maxb maxb deleted the new-kv-plugin-version branch July 26, 2023 04:51
@maxb
Copy link
Contributor Author

maxb commented Jul 26, 2023

Closed, as it looks like we'll not be using this diff as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KvV1Write, CubbyholeWrite, System.Wrap are unusable
2 participants