Chroot Listener #22304
Merged
Chroot Listener #22304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
ncabatoff
reviewed
Aug 14, 2023
divyaac
force-pushed
the
VAULT-17811_ChRoot_Listener
branch
from
d2b709b
to
5d350e1
Compare
ncabatoff
reviewed
Aug 14, 2023
| @@ -636,7 +638,12 @@ func (n *DockerClusterNode) Start(ctx context.Context, opts *DockerClusterOption | |||
| listener["address"] = fmt.Sprintf("%s:%d", "0.0.0.0", config.Port) | |||
| listener["chroot_namespace"] = config.ChrootNamespace | |||
| listenerConfig = append(listenerConfig, cfg) | |||
| ports = append(ports, fmt.Sprintf("%d/tcp", config.Port)) | |||
| portStr := fmt.Sprintf("%d/tcp", config.Port) | |||
| if portSet.Contains(portStr) { | |||
There was a problem hiding this comment.
I don't object to this approach, but note that the way we'd usually do it is strutil.StrListContains. That has the minor benefit of avoiding the need for an extra variable.
ncabatoff
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENT PR
https://github.com/hashicorp/vault-enterprise/pull/4369/files#