Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [QT-506] Use enos scenario samples for testing into release/1.15.x #22934

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

hc-github-team-secure-vault-core
Copy link
Contributor

Backport

This PR is auto-generated from #22641 to be assessed for backporting due to the inclusion of the label backport/1.15.x.

The below text is copied from the body of the original PR.


Replace our prior implementation of Enos test groups with the new Enos
sampling feature. With this feature we're able to describe which
scenarios and variant combinations are valid for a given artifact and
allow enos to create a valid sample field (a matrix of all compatible
scenarios) and take an observation (select some to run) for us. This
ensures that every valid scenario and variant combination will
now be a candidate for testing in the pipeline. See QT-504[0] for further
details on the Enos sampling capabilities.

Our prior implementation only tested the amd64 and arm64 zip artifacts,
as well as the Docker container. We now include the following new artifacts
in the test matrix:

  • CE Amd64 Debian package
  • CE Amd64 RPM package
  • CE Arm64 Debian package
  • CE Arm64 RPM package

Each artifact includes a sample definition for both pre-merge/post-merge
(build) and release testing.

Changes:

  • Remove the hand crafted enos-run-matrices ci matrix targets and replace
    them with per-artifact samples.
  • Use enos sampling to generate different sample groups on all pull
    requests.
  • Update the enos scenario matrices to handle HSM and FIPS packages.
  • Simpligy enos scenarios by using shared globals instead of
    cargo-culted locals.

Note: This will require coordination with vault-enterprise to ensure a
smooth migration to the new system. Integrating new scenarios or
modifying existing scenarios/variants should be much smoother after this
initial migration.

[0] hashicorp/enos#102

Signed-off-by: Ryan Cragun me@ryan.ec


Overview of commits

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Build Results:
All builds succeeded! ✅

@ryancragun ryancragun enabled auto-merge (squash) September 8, 2023 19:04
@ryancragun ryancragun merged commit c5579b1 into release/1.15.x Sep 8, 2023
102 of 103 checks passed
@ryancragun ryancragun deleted the backport/qt-506/completely-fresh-shrimp branch September 8, 2023 19:07
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

CI Results:
Failures:

Test Type Package Test Logs
http TestBexprFilters view test results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants