events: Ensure pipelines are cleaned up on closing subscription #23042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhjp
added
bug
|
Build Results: |
|
CI Results: |
|
The test failures were genuine: https://github.com/hashicorp/vault/actions/runs/6171703869/job/16750516454 The formatter node was never getting deregistered from the broker before, but now it could be if every last subscription is cancelled, so I moved registering it inside the subscribe function. It will be re-registered if there is already an existing subscription, but the broker allows us to do that unless we configure it not to. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while reviewing #23024. It seems the
brokerfield was never populated, so we never cleaned up the pipeline on close. However, we only need one method from the broker, so I narrowed the field down to one function as well.