Backport of events: Ensure pipelines are cleaned up on closing subscription into release/1.15.x #23063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/events-cleanup-pipeline-on-close/happily-subtle-joey
branch
from
d10da77
to
f5882d9
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/events-cleanup-pipeline-on-close/happily-subtle-joey
branch
from
3ac8df2
to
1d42180
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
tomhjp
approved these changes
Sep 13, 2023
|
Build Results: |
|
CI Results: |
…n-close/happily-subtle-joey
tomhjp
deleted the
backport/events-cleanup-pipeline-on-close/happily-subtle-joey
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #23042 to be assessed for backporting due to the inclusion of the label backport/1.15.x.
The below text is copied from the body of the original PR.
I noticed this while reviewing #23024. It seems the
brokerfield was never populated, so we never cleaned up the pipeline on close. However, we only need one method from the broker, so I narrowed the field down to one function as well.Overview of commits