Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: [VAULT-19982] confirm delete modal for namespaces #23066

Merged
merged 7 commits into from
Sep 14, 2023
Merged

Conversation

kiannaquach
Copy link
Contributor

@kiannaquach kiannaquach commented Sep 13, 2023

Description
Setting a height using inline styles directly in the template causes Content Security Policy errors.

Content Security Policy errors from putting inline styles:
Screenshot 2023-09-13 at 4 31 38 PM

The bug:
Screenshot 2023-09-13 at 2 57 14 PM

A few solutions to possibly prevent the Content Security Policy error:
Solution 1:
Instead of calculating the height, set a fixed min-height and add class with that min-height style. See possible solution 1 here: f5b785e
Solution 2:
Add the height style directly using js instead of in our templates. I paired with Jordan a little bit on this and found that this will likely not cause Content Security Policy errors since ember-basic-dropdown does something similar and injects some styling and these styles are set after initial render. See possible solution 2 here: 5fa9b68

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 13, 2023
@kiannaquach kiannaquach changed the title Possible soln 1: add a class w/ min height instead of calculated height UI: [VAULT-19982] confirm delete modal for namespaces Sep 13, 2023
@kiannaquach kiannaquach added this to the 1.14.3 milestone Sep 14, 2023
@kiannaquach kiannaquach added backport/1.14.x bug Used to indicate a potential bug pr/no-changelog labels Sep 14, 2023
@kiannaquach kiannaquach marked this pull request as ready for review September 14, 2023 15:34
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Build Results:
All builds succeeded! ✅

@kiannaquach kiannaquach modified the milestones: 1.14.3, 1.14.4 Sep 14, 2023
@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants