Backport of UI: [VAULT-19982] confirm delete modal for namespaces into release/1.15.x #23101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/confirm-bug/mostly-vocal-spider
branch
2 times, most recently
from
7a9db97
to
210c59a
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
kiannaquach
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #23066 to be assessed for backporting due to the inclusion of the label backport/1.15.x.
The below text is copied from the body of the original PR.
Description
Setting a height using inline styles directly in the template causes Content Security Policy errors.
Content Security Policy errors from putting inline styles:
The bug:
A few solutions to possibly prevent the Content Security Policy error:
Solution 1:
Instead of calculating the height, set a fixed
min-heightand addclasswith that min-height style. See possible solution 1 here: f5b785eSolution 2:
Add the height style directly using js instead of in our templates. I paired with Jordan a little bit on this and found that this will likely not cause Content Security Policy errors since
ember-basic-dropdowndoes something similar and injects some styling and these styles are set after initial render. See possible solution 2 here: 5fa9b68Overview of commits