Use our fork of bbolt to improve freelist performance #24010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
I should note that this is also an upgrade from 1.3.7 to 1.3.8, it's not only a backport of the freelist fix. |
|
CI Results: |
…s the official bbolt lib.
|
Build Results: |
ncabatoff
added
backport/1.13.x
mpalmi
approved these changes
Nov 20, 2023
hghaf099
approved these changes
Nov 20, 2023
| // is, assuming it can be parsed as an int. Bolt itself sets this to 0 by default, | ||
| // so if users are wanting to turn this off, they can also set it to 0. Setting it | ||
| // to a negative value is the same as not setting it at all. | ||
| if os.Getenv("VAULT_RAFT_INITIAL_MMAP_SIZE") == "" { |
There was a problem hiding this comment.
super nit: is there a reason that we are not following the same pattern as the above two options? Like setting the default in the instantiation of the struct, then consider overwriting it if the env var is set? Is the reason to have the comment on top of this line?
There was a problem hiding this comment.
Ah, I see there is similar implementation in boltOptions.
This was referenced Nov 21, 2023
ncabatoff
added a commit
that referenced
this pull request
Jan 17, 2024
ncabatoff
added a commit
that referenced
this pull request
Jan 17, 2024
ncabatoff
added a commit
that referenced
this pull request
Jan 22, 2024
ncabatoff
added a commit
that referenced
this pull request
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to adopt etcd-io/bbolt#585 before it appears in an official bbolt release.
Note that we're not modifying raft-boltdb yet, so raft.db (the bbolt file containing the raft log) doesn't benefit.