-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record the amount of free pages instead of hashmapFreeCount calculation #585
Conversation
Please also signoff the commits. please read https://github.com/etcd-io/bbolt/pull/585/checks?check_run_id=18046520663 |
I wanted to ask about that, it says:
I'm not in this case, so what should I do? |
You can manually added Or you can resubmit both commits for simplification (you will be the author of both commits). Thanks. |
Signed-off-by: xing0821 <54933318+xing0821@users.noreply.github.com>
Signed-off-by: ncabatoff <ncabatoff@hashicorp.com>
618b536
to
804c836
Compare
Ok, I've done the signoff as you proposed, thanks for the tips. I've also applied your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm Thanks for the contribution @ncabatoff ! |
…it's released officially.
This is an attempt to continue the work started in #282.