Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record the amount of free pages instead of hashmapFreeCount calculation #585

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

ncabatoff
Copy link
Contributor

This is an attempt to continue the work started in #282.

freelist_hmap.go Outdated Show resolved Hide resolved
freelist_test.go Outdated Show resolved Hide resolved
internal/common/verify.go Outdated Show resolved Hide resolved
@ahrtr
Copy link
Member

ahrtr commented Oct 26, 2023

Please also signoff the commits. please read https://github.com/etcd-io/bbolt/pull/585/checks?check_run_id=18046520663

@ncabatoff
Copy link
Contributor Author

Please also signoff the commits. please read https://github.com/etcd-io/bbolt/pull/585/checks?check_run_id=18046520663

I wanted to ask about that, it says:

You should only do this if:

  • You are the only author of the commits in this branch

I'm not in this case, so what should I do?

@ahrtr
Copy link
Member

ahrtr commented Oct 26, 2023

I'm not in this case, so what should I do?

You can manually added Signed-off-by: <author's email> for each commit. Since we don't know the original auther's email address, we can use the form of ID+USERNAME@users.noreply.github.com. Please refer to about-commit-email-addresses.

Or you can resubmit both commits for simplification (you will be the author of both commits).

Thanks.

xinglong and others added 2 commits October 26, 2023 09:03
Signed-off-by: xing0821 <54933318+xing0821@users.noreply.github.com>
Signed-off-by: ncabatoff <ncabatoff@hashicorp.com>
@ncabatoff
Copy link
Contributor Author

Ok, I've done the signoff as you proposed, thanks for the tips. I've also applied your feedback.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thx @ncabatoff

cc @tjungblu to take another look.

@tjungblu
Copy link
Contributor

tjungblu commented Oct 26, 2023

/lgtm

Thanks for the contribution @ncabatoff !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants