Fix memory issue caused by append of group slice to itself. #5611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The slice returned by `collectGroupsReverseDFS` is an updated copy of the slice given to it when called. Appending `pGroups` to `groups` therefore led to expontential memory usage as the slice was repeatedly appended to itself. Fixes hashicorp#5605
vishalnayak
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slice returned by
collectGroupsReverseDFSis an updated copy ofthe slice given to it when called. Appending
pGroupstogroupstherefore led to expontential memory usage as the slice was repeatedly
appended to itself.
Fixes #5605