Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory issue caused by append of group slice to itself. #5611

Merged
merged 2 commits into from Oct 29, 2018
Merged

Fix memory issue caused by append of group slice to itself. #5611

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7404fc5
Fix memory issue caused by append of group slice to itself.
c2nes Oct 25, 2018
26e0ea5
Merge branch 'master' into identity-group-lookup-mem-usage
vishalnayak Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions vault/identity_store_util.go
View file
Open in desktop
Expand Up @@ -1566,11 +1566,10 @@ func (i *IdentityStore) collectGroupsReverseDFS(group *identity.Group, visited m
if parentGroup == nil {
continue
}
pGroups, err := i.collectGroupsReverseDFS(parentGroup, visited, groups)
groups, err = i.collectGroupsReverseDFS(parentGroup, visited, groups)
if err != nil {
return nil, fmt.Errorf("failed to collect group at parent group ID %q", parentGroup.ID)
}
groups = append(groups, pGroups...)
}

return groups, nil
Expand Down