Kerberos docs #7993
Merged
Kerberos docs #7993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrannosaurus-becks
requested review from
kalafut,
malnick,
catsby,
jasonodonnell and
pcman312
xntrik
reviewed
Dec 9, 2019
jasonodonnell
previously approved these changes
Dec 11, 2019
| - `starttls` `(bool: false)` – If true, issues a `StartTLS` command after | ||
| establishing an unencrypted connection. | ||
| - `tls_min_version` `(string: tls12)` – Minimum TLS version to use. Accepted | ||
| values are `tls10`, `tls11` or `tls12`. |
There was a problem hiding this comment.
I'm surprised we even allow TLS 1.0.
There was a problem hiding this comment.
Yeah. It's mainly to support legacy applications that don't support anything higher than tls10. I think the idea is, something's better than nothing.
kalafut
reviewed
Dec 11, 2019
kalafut
reviewed
Dec 11, 2019
tyrannosaurus-becks
dismissed stale reviews from kalafut, jasonodonnell, and catsby
via
6894928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides documentation for the
kerberosauth method being added in #7908. I've viewed all these docs locally and they render nicely.