Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kerberos SPNEGO auth plugin #7908

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Add Kerberos SPNEGO auth plugin #7908

merged 3 commits into from
Dec 11, 2019

Conversation

tyrannosaurus-becks
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks commented Nov 19, 2019 •
edited
Loading

This PR adds a "kerberos" auth method to Vault, along with a login handler, that supports SPNEGO authentication.

TODO (in separate PRs):

  • Add an agent
  • Add docs

@tyrannosaurus-becks tyrannosaurus-becks marked this pull request as ready for review December 9, 2019 19:44
@tyrannosaurus-becks tyrannosaurus-becks added this to the 1.4 milestone Dec 9, 2019
jasonodonnell
jasonodonnell reviewed Dec 9, 2019
View reviewed changes
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll defer to others who have a deeper understanding on Go mod.

@tyrannosaurus-becks tyrannosaurus-becks mentioned this pull request Dec 9, 2019
Merged
catsby
catsby previously approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, just need to bump the vendored version to the newly released v0.1.1

go.mod Outdated Show resolved Hide resolved
@tyrannosaurus-becks tyrannosaurus-becks merged commit 73fd8f3 into master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonodonnell jasonodonnell jasonodonnell left review comments

@catsby catsby catsby left review comments

@kalafut kalafut Awaiting requested review from kalafut

@malnick malnick Awaiting requested review from malnick

@pcman312 pcman312 Awaiting requested review from pcman312

Assignees
No one assigned
Labels
auth/kerberos
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@tyrannosaurus-becks @catsby @jasonodonnell