Fix DB static role credential rotation replication issue #8105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briankassouf
reviewed
Jan 7, 2020
|
Maybe we should get this merged so it can be used here and in your other PR? #7175 |
|
#7175 is now merged. |
michelvocks
force-pushed
the
fix_db_static_rotate_replication_issue
branch
from
dc7f79b
to
8511489
Compare
|
Thanks, @kalafut & @briankassouf! Done |
briankassouf
reviewed
Jan 8, 2020
briankassouf
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that prevents Vault performance secondaries and performance standby's to successfully forward a manual static role credential rotation request e.g.
vault write -f database/rotate-role/education.To prevent the client to run in a timeout:
vault/http/handler.go
Line 642 in 31bbb81
And the manual static role credential rotation method does not store anything in the backend (which usually triggers a guard check), we have to store a canary to make sure that a guard check is triggered.