implemented a new feature that Hashie::Mash.load accepts a Pathname object #331 #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failure/Error: file = Tempfile.new
ArgumentError:
wrong number of arguments (0 for 1..2)
| @@ -11,6 +11,7 @@ def initialize(file_path) | |||
|
|
|||
| def perform | |||
| template = ERB.new(@content) | |||
| @file_path = @file_path.to_s if @file_path.respond_to? :to_s | |||
There was a problem hiding this comment.
I don't think this is the right place to do this, if perform is called over and over again it's wasteful, and it's modifying the state of the object which feels like a side effect. Furthermore if I pass some junk that responds to to_s here we'll just try to load that, and that doesn't seem safe.
Ideally this should be directly supported by YAML.load, but short of that I would do this in initialize and more explicitly.
@file_path = file_path.is_a?(Pathname) ? file_path.to_s : file_path
|
Please also squash your commits and update CHANGELOG and README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested on #331, I implemented the feature so that Hashie::Mash can also load a Pathname object.