Fix builds breaking due to Rake 11 #387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rake 11 has a breaking change (removal of the
#last_comment
method) that doesn't work with our current version of RSpec and Rubocop. Updating RSpec was simple, but we have to update so far in Rubocop that there were a ton of changes that would be required.This clamps the version of Rake that we use to
< 11
. This should be a temporary fix, but will let us actually have passing builds on Travis again.