Support Ruby 2.4.0 #389
Support Ruby 2.4.0 #389
Conversation
|
If you can get the build to be green we could take it. Add ruby 2.4.0 to the build matrix. |
|
@dblock Thanks for response. I'll fix that tomorrow 👍 |
|
I think we might need to start using |
|
Or you can do some |
camelmasa
force-pushed
the
bump-as
branch
3 times, most recently
from
e2ccf3f
to
8216e95
Compare
|
@michaelherold @dblock Thank you for suggestions. I updated a commit. That was passed tests.
I'll continue to add commits on this PR.
|
camelmasa
changed the title
|
I added commits and updated CHANGELOG. @dblock Could you review when you have time ❓ |
|
Looks good to me, merging. |
|
@dblock Thanks ! |
|
I'd like to use hashie with Ruby 2.4 too. Do you guys have an idea when I'll release the next version? |
|
I don't think there's anything holding that up. I can work on getting a release out tomorrow unless @dblock knows of some reason we should hold off. |
|
@michaelherold that would be great, thanks! And if there's anything I can do to help, I'm willing to. |
|
I hereby issue an executive order to release the next version of Hashie! 😢 |
|
More seriously, thanks so much for your help @michaelherold! |
|
Hmm 🤔 We have a change that is listed in the upgrading document that is technically a breaking change. It feels more like a bug fix to me than a change of contract. Thus, I don't think we need a major version bump. I do think we need a minor version bump to 3.5.0 since we have the added functionality of Hashie::Logger in this release. Do you agree? |
|
I agree. |
|
Done, thanks for the kick in the pants, @lsdr! |
|
Awesome! Thank you @michaelherold and @dblock! |
# Change Log ## [3.5.5] - 2017-02-24 [3.5.5]: hashie/hashie@v3.5.4...v3.5.5 ### Added * [#326](hashie/hashie#326): Added `Hashie::Extensions::Mash::KeepOriginalKeys` to give Mashes the ability to keep the original structure given to it - [@michaelherold](https://github.com/michaelherold). ### Fixed * [#415](hashie/hashie#415): Fixed Mash logging keys multiple times which lead to a bad user experience or, in some cases, errors - [@michaelherold](https://github.com/michaelherold). ## [3.5.4] - 2017-02-22 [3.5.4]: hashie/hashie@v3.5.3...v3.5.4 ### Added * [#412](hashie/hashie#412): Added a Hashie::Extensions::Mash::SymbolizeKeys extension that overrides the default stringification behavior for keys - [@michaelherold](https://github.com/michaelherold). ### Fixed * [#409](hashie/hashie#409): Fixed Railtie detection for projects where Rails is defined but Railties are not availble - [@CallumD](https://github.com/callumd). * [#411](hashie/hashie#411): Fixed a performance regression from 3.4.3 that caused a 10x slowdown in OmniAuth - [@michaelherold](https://github.com/michaelherold). ## [3.5.3] - 2017-02-11 [3.5.3]: hashie/hashie@v3.5.2...v3.5.3 ### Fixed * [#402](hashie/hashie#402): Use a Railtie to set Hashie.logger on rails boot - [@matthewrudy](https://github.com/matthewrudy). * [#406](hashie/hashie#406): Ensure that subclasses that disable warnings propagate that setting to grandchild classes - [@michaelherold](https://github.com/michaelherold). * Your contribution here. ## [3.5.2] - 2017-02-10 [3.5.2]: hashie/hashie@v3.5.1...v3.5.2 ### Added * [#395](hashie/hashie#395): Add the ability to disable warnings in Mash subclasses - [@michaelherold](https://github.com/michaelherold). * [#400](hashie/hashie#400): Fix Hashie.logger load and set the Hashie logger to the Rails logger in a Rails environment - [@michaelherold](https://github.com/michaelherold). ### Fixed * [#396](hashie/hashie#396): Fix for specs in #381: Incorrect use of shared context meant example was not being run - [@biinari](https://github.com/biinari). * [#399](hashie/hashie#399): Fix passing Pathname object to Hashie::Mesh.load() - [@albb0920](https://github.com/albb0920). ### Miscellanous * [#397](hashie/hashie#397): Add the integration specs harness into the main test tasks - [@michaelherold](https://github.com/michaelherold). ## [3.5.1] - 2017-01-31 * [#392](hashie/hashie#392): Fix for #391: Require all dependencies of Hashie::Mash - [@dblock](https://github.com/dblock). [3.5.1]: hashie/hashie@v3.5.0...v3.5.1 ## [3.5.0] - 2017-01-31 * [#386](hashie/hashie#386): Fix for #385: Make `deep_merge` always `deep_dup` nested hashes before merging them in so that there are no shared references between the two hashes being merged. - [@mltsy](https://github.com/mltsy). * [#389](hashie/hashie#389): Support Ruby 2.4.0 - [@camelmasa](https://github.com/camelmasa). [3.5.0]: hashie/hashie@v3.4.6...v3.5.0 ### Added * [#381](hashie/hashie#381): Add a logging layer that lets us report potential issues to our users. As the first logged issue, report when a `Hashie::Mash` is attempting to overwrite a built-in method, since that is one of our number one questions - [@michaelherold](https://github.com/michaelherold). ### Changed * [#384](hashie/hashie#384): Updated to CodeClimate 1.x - [@boffbowsh](https://github.com/boffbowsh). ### Fixed * [#369](hashie/hashie#369): If a translation for a property exists when using IndifferentAccess and IgnoreUndeclared, use the translation to find the property - [@whitethunder](https://github.com/whitethunder). * [#376](hashie/hashie#376): Leave string index unchanged if it can't be converted to integer for Array#dig - [@sazor](https://github.com/sazor). * [#377](hashie/hashie#377): Dont use Rubygems to check ruby version - [@sazor](https://github.com/sazor). * [#378](hashie/hashie#378): Deep find all searches inside all nested hashes - [@sazor](https://github.com/sazor). * [#380](hashie/hashie#380): Evaluate procs default values of Dash in object initialization - [@sazor](https://github.com/sazor). ### Miscellanous * [#387](hashie/hashie#387): Fix builds failing due to Rake 11 having a breaking change - [@michaelherold](https://github.com/michaelherold).
I'd like to use this gem with Ruby 2.4.0.
I couldn't
bundle installusing Ruby 2.4.0 because activesupport 4.x is depending oldjsongem.