Allow mash error silencing

[BobbyMcWho]

re: #485 and #487
@dblock @michaelherold thoughts?

[dblock]

I think I like this better. Naming-wise I think this is not about warnings, it's about overriding methods that otherwise come from the base class. So maybe we mean subclass instead of quiet?

[michaelherold]

I like that this gives more flexibility around disabling warnings over #487. However, in #485, @nonnenmacher specificly calls out Mash.load as a culprit for annoyance with the warnings. Personally, I would rather extract Mash.load into a companion gem and get rid of it, but since it's here we should think about addressing that case.

Do you have any thoughts on how we could incorporate this into Mash.load? Also, I'd love to hear @nonnenmacher's thoughts on this.

[BobbyMcWho]

I like that this gives more flexibility around disabling warnings over #487. However, in #485, @nonnenmacher specificly calls out Mash.load as a culprit for annoyance with the warnings. Personally, I would rather extract Mash.load into a companion gem and get rid of it, but since it's here we should think about addressing that case.

@michaelherold this works with load as well Hashie::Mash.quiet.load(path, parser: parser)

[michaelherold]

🤦‍♂ Of course it does ... 🤦‍♂

[michaelherold]

I'm wondering if we should do some sort of caching so we don't generate a new class every time we call .quiet. Maybe a lookup table with keys based on the method keys you send to the method?

Otherwise, I really like this approach! 👍

[BobbyMcWho]

Interesting thought, I may have some time later to look into that

[dblock]

I'm wondering if we should do some sort of caching so we don't generate a new class every time we call .quiet. Maybe a lookup table with keys based on the method keys you send to the method?

One argument against is that quiet would work like merge, always generating a new thing. Maybe we can also have quiet! that mutates the existing class?

[BobbyMcWho]

One argument against is that quiet would work like merge, always generating a new thing. Maybe we can also have quiet! that mutates the existing class?

Since we're only memoizing the classes and not the objects instantiated from them, I don't think we need to worry about a non-mutating and mutating method, I'd be open to hearing opposition if I'm not thinking this through all the way 😅

[dblock]

I think this is pretty much there AFAIK. A bit of cleanup and we're good to go?

[BobbyMcWho]

I think this handles most use cases, faraday_middleware supports passing a custom mash class in which was one of the other concerns.

[BobbyMcWho]

Seems like my autoload isn't working in some of the integration tests... do either of you see anything wrong with how I'm autoloading the new extension?

[michaelherold]

I think the explicit require is the right move, particularly since we don't use it anywhere else. I'd hedge on removing the autoload, TBH.

[nonnenmacher]

I like that this gives more flexibility around disabling warnings over #487. However, in #485, @nonnenmacher specificly calls out Mash.load as a culprit for annoyance with the warnings. Personally, I would rather extract Mash.load into a companion gem and get rid of it, but since it's here we should think about addressing that case.

@michaelherold this works with load as well Hashie::Mash.quiet.load(path, parser: parser)

Sound nice !
and would do perfectly I guess

especially if the parser is an argument, as one of the problem of Safe_yaml and underlying implementation (e.g psych versus sick) don't allow passing options from the parse call).

[nonnenmacher]

I think this handles most use cases, faraday_middleware supports passing a custom mash class in which was one of the other concerns.

yep it does, especially as the two mains cases where we have the problems and often are out of reach for code modification (i.e because we can't modify the data) are
-- loading configurations that have defined/not changeable names
-- REST responses that contains attributes out of reach (e.g this zip thing)

[dblock]

I'm good with this, @michaelherold?

[michaelherold]

Go for it!

[dblock]

Merged.