Forbid unsafe code in the HASH graph #1064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
We don't use any unsafe code in the HASH graph datastore, and we should avoid it if not strictly necessary. Forbidding
unsafe
also implies, that we don't require to runmiri
on CI, which (a) speeds up CI and (b) allows us to use toolchains, wheremiri
is not available.🔍 What does this change?
#![deny(...)]
allows further#![allow]
statements,#![forbid(...)
does not)miri
📜 Does this require a change to the docs?
Next to the statement, I put a comment on how we want to proceed, if we require
unsafe
: We should prefer#![deny(...)]
over removing the statement, unless this gets too verbose.📹 Demo